[wasm] Use more precise types for some WASM objects.

[wasm] Use more precise types for some WASM objects.

R=clemensh@chromium.org,mtrofin@chromium.org
BUG=

Committed: https://crrev.com/72c3732f0f98ebc738053994005c905d117b232d
Cr-Commit-Position: refs/heads/master@{#41043}

[titzer, 2016-11-16 13:08:29]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 13:08:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 13:33:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 13:33:44]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-11-16 15:27:38]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 15:27:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2016-11-16 15:37:45]

PTAL

[Clemens Hammacher, 2016-11-16 15:46:38]

lgtm with one nit

https://codereview.chromium.org/2510673002/diff/20001/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/2510673002/diff/20001/src/wasm/wasm-module.cc...
src/wasm/wasm-module.cc:679: return nullptr;
Can you just do it the other way around? It's better style (early exits) and
more in line with the rest of the function.
if (!cell->value()) return nullptr;
return ...cast...

[titzer, 2016-11-16 15:52:38]

On 2016/11/16 15:46:38, Clemens Hammacher wrote:
> lgtm with one nit
> 
> https://codereview.chromium.org/2510673002/diff/20001/src/wasm/wasm-module.cc
> File src/wasm/wasm-module.cc (right):
> 
>
https://codereview.chromium.org/2510673002/diff/20001/src/wasm/wasm-module.cc...
> src/wasm/wasm-module.cc:679: return nullptr;
> Can you just do it the other way around? It's better style (early exits) and
> more in line with the rest of the function.
> if (!cell->value()) return nullptr;
> return ...cast...

Done.

[titzer, 2016-11-16 15:52:42]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-11-16 15:52:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
clemensh@chromium.org
Link to the patchset: https://codereview.chromium.org/2510673002/#ps40001
(title: "Address review comment.")

[commit-bot: I haz the power, 2016-11-16 15:52:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 16:17:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-17 22:36:38]

Description was changed from

==========
[wasm] Use more precise types for some WASM objects.

R=clemensh@chromium.org,mtrofin@chromium.org
BUG=
==========

to

==========
[wasm] Use more precise types for some WASM objects.

R=clemensh@chromium.org,mtrofin@chromium.org
BUG=

Committed: https://crrev.com/72c3732f0f98ebc738053994005c905d117b232d
Cr-Commit-Position: refs/heads/master@{#41043}
==========

[commit-bot: I haz the power, 2016-11-17 22:36:39]

Patchset 3 (id:??) landed as
https://crrev.com/72c3732f0f98ebc738053994005c905d117b232d
Cr-Commit-Position: refs/heads/master@{#41043}