Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Unified Diff: src/ic/accessor-assembler.cc

Issue 2510653002: [ic] Pass name to LoadGlobalIC again. (Closed)
Patch Set: Release fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen/full-codegen.cc ('k') | src/interface-descriptors.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic/accessor-assembler.cc
diff --git a/src/ic/accessor-assembler.cc b/src/ic/accessor-assembler.cc
index e2e34e9ee3147c6f21d91e433ff7b655162d3929..2f1a97ec172b571c1af7028eb8596f60a60540ad 100644
--- a/src/ic/accessor-assembler.cc
+++ b/src/ic/accessor-assembler.cc
@@ -1170,8 +1170,7 @@ void AccessorAssemblerImpl::LoadGlobalIC(const LoadICParameters* p) {
Node* native_context = LoadNativeContext(p->context);
Node* receiver =
LoadContextElement(native_context, Context::EXTENSION_INDEX);
- Node* fake_name = IntPtrConstant(0);
- TailCallStub(descriptor, handler, p->context, receiver, fake_name, p->slot,
+ TailCallStub(descriptor, handler, p->context, receiver, p->name, p->slot,
p->vector);
}
Bind(&miss);
@@ -1569,22 +1568,24 @@ void AccessorAssemblerImpl::GenerateLoadICProtoArray() {
void AccessorAssemblerImpl::GenerateLoadGlobalIC() {
typedef LoadGlobalICStub::Descriptor Descriptor;
+ Node* name = Parameter(Descriptor::kName);
Node* slot = Parameter(Descriptor::kSlot);
Node* vector = Parameter(Descriptor::kVector);
Node* context = Parameter(Descriptor::kContext);
- LoadICParameters p(context, nullptr, nullptr, slot, vector);
+ LoadICParameters p(context, nullptr, name, slot, vector);
LoadGlobalIC(&p);
}
void AccessorAssemblerImpl::GenerateLoadGlobalICTrampoline() {
typedef LoadGlobalICTrampolineStub::Descriptor Descriptor;
+ Node* name = Parameter(Descriptor::kName);
Node* slot = Parameter(Descriptor::kSlot);
Node* context = Parameter(Descriptor::kContext);
Node* vector = LoadTypeFeedbackVectorForStub();
- LoadICParameters p(context, nullptr, nullptr, slot, vector);
+ LoadICParameters p(context, nullptr, name, slot, vector);
LoadGlobalIC(&p);
}
« no previous file with comments | « src/full-codegen/full-codegen.cc ('k') | src/interface-descriptors.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698