Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 251064: Fix focus restore bug in find-in-bar (Closed)

Created:
11 years, 2 months ago by jcampan
Modified:
9 years, 7 months ago
Reviewers:
Finnur
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, tim (not reviewing), Paweł Hajdan Jr.
Visibility:
Public.

Description

The focus would only be restored properly the first time the find-in-bar box was closed. Also wrote an interactive ui test and took the opportunity to convert the existing find-in-bar interactive ui test to be a browser test. BUG=23599 TEST=See bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27875

Patch Set 1 #

Total comments: 16

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -183 lines) Patch
M chrome/browser/views/find_bar_host.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/views/find_bar_host_browsertest.cc View 18 chunks +123 lines, -125 lines 0 comments Download
M chrome/browser/views/find_bar_host_interactive_uitest.cc View 1 2 chunks +106 lines, -53 lines 0 comments Download
M chrome/test/ui_test_utils.h View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/test/ui_test_utils.cc View 1 2 chunks +60 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jcampan
11 years, 2 months ago (2009-10-02 00:22:11 UTC) #1
Finnur
Make the changes necessary to get Mac and Linux compiling and I'll take a better ...
11 years, 2 months ago (2009-10-02 03:55:23 UTC) #2
Finnur
Also, a few comments. Mostly just nits. http://codereview.chromium.org/251064/diff/1/4 File chrome/browser/views/find_bar_host_interactive_uitest.cc (right): http://codereview.chromium.org/251064/diff/1/4#newcode35 Line 35: void ...
11 years, 2 months ago (2009-10-02 04:28:40 UTC) #3
jcampan
http://codereview.chromium.org/251064/diff/1/4 File chrome/browser/views/find_bar_host_interactive_uitest.cc (right): http://codereview.chromium.org/251064/diff/1/4#newcode35 Line 35: void ClickOnView(ViewID vid) { On 2009/10/02 04:28:40, Finnur ...
11 years, 2 months ago (2009-10-02 16:39:18 UTC) #4
Finnur
11 years, 2 months ago (2009-10-02 17:35:16 UTC) #5
LG, one nit.

http://codereview.chromium.org/251064/diff/1/4
File chrome/browser/views/find_bar_host_interactive_uitest.cc (right):

http://codereview.chromium.org/251064/diff/1/4#newcode55
Line 55: #if defined(TOOLKIT_VIEWS) || defined(OS_WIN)
Just remove OS_WIN, I guess. This file is built only on Win anyway.

On 2009/10/02 16:39:18, jcampan wrote:
> On 2009/10/02 04:28:40, Finnur wrote:
> > I forget how TOOLKIT_VIEWS is defined... but if you need to OR it with
OS_WIN,
> > then how does |view| get defined on OS_WIN in the function above this one?
> 
> It does not really matter as this file is only built on Windows at this point.
> We'll have to worry about this when we port this file to Linux.

Powered by Google App Engine
This is Rietveld 408576698