Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 2510633006: Move enable_wifi_display out of root build configuration. (Closed)

Created:
4 years, 1 month ago by brettw
Modified:
4 years, 1 month ago
Reviewers:
e_hakkinen, Mikhail
CC:
chromium-reviews, extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, chromium-apps-reviews_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move enable_wifi_display out of root build configuration. The build flag and define have moved to the extensions features, and the define has been converted to a buildflag header for scalability. Committed: https://crrev.com/cb33b243721b0e7dbdfa8c4301702e319360e88d Cr-Commit-Position: refs/heads/master@{#433432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -13 lines) Patch
M build/config/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M build/config/features.gni View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/api/display_source/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/mojo/service_registration.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M extensions/features/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M extensions/features/features.gni View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/renderer/api/display_source/display_source_session.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
brettw
The context is I'm trying to get the feature defines out of the root build ...
4 years, 1 month ago (2016-11-17 20:35:18 UTC) #2
brettw
Just realized Mikhail added the flag initially so I'm adding him.
4 years, 1 month ago (2016-11-17 20:37:24 UTC) #6
Mikhail
lgtm
4 years, 1 month ago (2016-11-18 07:20:06 UTC) #9
e_hakkinen
lgtm
4 years, 1 month ago (2016-11-18 10:51:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510633006/1
4 years, 1 month ago (2016-11-19 20:26:58 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-19 23:59:36 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-20 00:01:15 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb33b243721b0e7dbdfa8c4301702e319360e88d
Cr-Commit-Position: refs/heads/master@{#433432}

Powered by Google App Engine
This is Rietveld 408576698