Chromium Code Reviews
DescriptionRevert of Take size in ink drop masks instead of bounds (patchset #1 id:1 of https://codereview.chromium.org/2508063004/ )
Reason for revert:
compile failure on Windows - https://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/32175/steps/compile/logs/stdio
'views::CircleInkDropMask::CircleInkDropMask(const views::CircleInkDropMask &)': cannot convert argument 1 from 'const gfx::Rect' to 'const gfx::Size &'
Original issue's description:
> Take size in ink drop masks instead of bounds
>
> Currently, constructors for ink drop masks, take layer bounds which is
> expected to have (0, 0) as their origin. It's better for them to take
> size instead.
>
> BUG=612573
> TEST=none
>
> Committed: https://crrev.com/431883e99a2fcdc5e6e54868ac98d3474aaaf198
> Cr-Commit-Position: refs/heads/master@{#432898}
TBR=bruthig@chromium.org,jamescook@chromium.org,mohsen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=612573
Committed: https://crrev.com/805a5e5f29072e481bb9cd245751d39da874a10b
Cr-Commit-Position: refs/heads/master@{#432899}
Patch Set 1 #
Messages
Total messages: 8 (3 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||