Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2510633004: Revert of Take size in ink drop masks instead of bounds (Closed)

Created:
4 years, 1 month ago by Evan Stade
Modified:
4 years, 1 month ago
Reviewers:
James Cook, mohsen, bruthig
CC:
bruthig+ink_drop_chromium.org, chromium-reviews, dcheng, kalyank, sadrul, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Take size in ink drop masks instead of bounds (patchset #1 id:1 of https://codereview.chromium.org/2508063004/ ) Reason for revert: compile failure on Windows - https://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/32175/steps/compile/logs/stdio 'views::CircleInkDropMask::CircleInkDropMask(const views::CircleInkDropMask &)': cannot convert argument 1 from 'const gfx::Rect' to 'const gfx::Size &' Original issue's description: > Take size in ink drop masks instead of bounds > > Currently, constructors for ink drop masks, take layer bounds which is > expected to have (0, 0) as their origin. It's better for them to take > size instead. > > BUG=612573 > TEST=none > > Committed: https://crrev.com/431883e99a2fcdc5e6e54868ac98d3474aaaf198 > Cr-Commit-Position: refs/heads/master@{#432898} TBR=bruthig@chromium.org,jamescook@chromium.org,mohsen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=612573 Committed: https://crrev.com/805a5e5f29072e481bb9cd245751d39da874a10b Cr-Commit-Position: refs/heads/master@{#432899}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M ash/common/shelf/app_list_button.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/common/system/tray/tray_background_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/animation/ink_drop_mask.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/animation/ink_drop_mask.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Evan Stade
Created Revert of Take size in ink drop masks instead of bounds
4 years, 1 month ago (2016-11-17 17:23:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510633004/1
4 years, 1 month ago (2016-11-17 17:23:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 17:24:29 UTC) #5
bruthig
lgtm
4 years, 1 month ago (2016-11-17 17:28:11 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 17:37:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/805a5e5f29072e481bb9cd245751d39da874a10b
Cr-Commit-Position: refs/heads/master@{#432899}

Powered by Google App Engine
This is Rietveld 408576698