Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2510623002: Revert of Move ProcessHeap::isLowEndDevice to MemoryCoordinator (Closed)

Created:
4 years, 1 month ago by suzyh_UTC10 (ex-contributor)
Modified:
4 years, 1 month ago
Reviewers:
haraken, whywhat
CC:
Mads Ager (chromium), blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, kouhei+heap_chromium.org, loading-reviews+fetch_chromium.org, oilpan-reviews, tyoshino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move ProcessHeap::isLowEndDevice to MemoryCoordinator (patchset #2 id:20001 of https://codereview.chromium.org/2503433003/ ) Reason for revert: Suspected to be responsible for breaking blink heap unittests. Original issue's description: > Move ProcessHeap::isLowEndDevice to MemoryCoordinator > > Per discussion at https://codereview.chromium.org/2475293003 > > BUG=None > > Committed: https://crrev.com/6d436afa31364d59752915155a40e8afba13cd03 > Cr-Commit-Position: refs/heads/master@{#432427} TBR=haraken@chromium.org,avayvod@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/43f565bb89ae5308873f3dbfde3b797bb3a7201a Cr-Commit-Position: refs/heads/master@{#432441}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M third_party/WebKit/Source/core/fetch/MemoryCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/MemoryCoordinator.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/MemoryCoordinator.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
suzyh_UTC10 (ex-contributor)
Created Revert of Move ProcessHeap::isLowEndDevice to MemoryCoordinator
4 years, 1 month ago (2016-11-16 09:13:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510623002/1
4 years, 1 month ago (2016-11-16 09:14:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 09:14:59 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/43f565bb89ae5308873f3dbfde3b797bb3a7201a Cr-Commit-Position: refs/heads/master@{#432441}
4 years, 1 month ago (2016-11-16 09:18:08 UTC) #6
haraken
LGTM Would you add a link to the test failure?
4 years, 1 month ago (2016-11-16 11:27:10 UTC) #7
whywhat
On 2016/11/16 at 11:27:10, haraken wrote: > LGTM > > Would you add a link ...
4 years, 1 month ago (2016-11-16 17:42:15 UTC) #8
suzyh_UTC10 (ex-contributor)
4 years, 1 month ago (2016-11-16 22:22:05 UTC) #9
Message was sent while issue was closed.
On 2016/11/16 at 17:42:15, avayvod wrote:
> On 2016/11/16 at 11:27:10, haraken wrote:
> > LGTM
> > 
> > Would you add a link to the test failure?
> 
> Yeah, the tests pass locally on Linux for me :/


My sincere apologies for not including enough info. Here is the failure that I
was looking at:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/build...

Powered by Google App Engine
This is Rietveld 408576698