Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2510613002: Loading: move TextResource to core/loader/resource (Closed)

Created:
4 years, 1 month ago by Takashi Toyoshima
Modified:
4 years ago
CC:
chromium-reviews, tyoshino+watch_chromium.org, blink-reviews-style_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Loading: move TextResource to core/loader/resource To remove core/ dependency so that core/fetch can be moved under platform, move TextResource and TextResourceClient classes to core/loader/resource/. BUG=655920 Committed: https://crrev.com/87a093df53d87549a8b1d54850b15af9a477bcc5 Cr-Commit-Position: refs/heads/master@{#435885}

Patch Set 1 #

Patch Set 2 : [rebase] #

Patch Set 3 : fix rebase error #

Messages

Total messages: 20 (13 generated)
hiroshige
lgtm
4 years, 1 month ago (2016-11-17 06:27:10 UTC) #3
Takashi Toyoshima
+kouhei fyi yhirano: now this is rebased and does not have any dependency.
4 years ago (2016-12-01 10:05:30 UTC) #5
yhirano
lgtm
4 years ago (2016-12-01 10:10:19 UTC) #9
kouhei (in TOK)
lgtm
4 years ago (2016-12-01 10:20:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510613002/40001
4 years ago (2016-12-02 08:17:35 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-02 08:23:08 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-02 08:25:45 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/87a093df53d87549a8b1d54850b15af9a477bcc5
Cr-Commit-Position: refs/heads/master@{#435885}

Powered by Google App Engine
This is Rietveld 408576698