Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: ash/common/system/tray/tray_background_view.h

Issue 2510603003: Add ink drop ripple to status tray (Closed)
Patch Set: Addressed review comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/tray/tray_background_view.h
diff --git a/ash/common/system/tray/tray_background_view.h b/ash/common/system/tray/tray_background_view.h
index 4a72dda62f34765ed11392e2b5292618367841dd..e59979f70ac4e517586c9b33608919ba4669bb9c 100644
--- a/ash/common/system/tray/tray_background_view.h
+++ b/ash/common/system/tray/tray_background_view.h
@@ -13,6 +13,7 @@
#include "ash/public/cpp/shelf_types.h"
#include "base/macros.h"
#include "ui/compositor/layer_animation_observer.h"
+#include "ui/gfx/geometry/insets.h"
#include "ui/views/bubble/tray_bubble_view.h"
namespace ash {
@@ -158,6 +159,13 @@ class ASH_EXPORT TrayBackgroundView : public ActionableView,
// SetVisible(false) is called.
void HideTransformation();
+ // Helper function that returns background insets relative to local bounds.
tdanderson 2016/11/17 23:55:21 nit: perhaps "calculates" instead of "returns" ?
mohsen 2016/11/18 05:20:56 Done.
+ gfx::Insets GetBackgroundInsets() const;
+
+ // Helper function that calculates ink drop bounds relative to local bounds
+ // based on the background insets returned from GetBackgroundInsets().
+ gfx::Rect GetInkDropBounds() const;
+
// The shelf containing the system tray for this view.
WmShelf* wm_shelf_;

Powered by Google App Engine
This is Rietveld 408576698