Early terminate WebGL markContextChanged calls when appropriate

Early terminate WebGL markContextChanged calls when appropriate

Slightly modified version of bajones's patch at:
https://codereview.chromium.org/1947763002/

BUG=608873
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/84361b5e33d34f6075aa2cdf13e3f6301903571f
Cr-Commit-Position: refs/heads/master@{#435380}

[Kai Ninomiya, 2016-11-17 00:01:58]

Description was changed from

==========
Early terminate WebGL markContextChanged calls when appropriate

BUG=608873
==========

to

==========
Early terminate WebGL markContextChanged calls when appropriate

BUG=608873
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-11-17 00:03:19]

Description was changed from

==========
Early terminate WebGL markContextChanged calls when appropriate

BUG=608873
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Early terminate WebGL markContextChanged calls when appropriate

Slightly modified version of bajone's patch at:
https://codereview.chromium.org/1947763002/

BUG=608873
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-11-17 02:47:47]

Description was changed from

==========
Early terminate WebGL markContextChanged calls when appropriate

Slightly modified version of bajone's patch at:
https://codereview.chromium.org/1947763002/

BUG=608873
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Early terminate WebGL markContextChanged calls when appropriate

Slightly modified version of bajones's patch at:
https://codereview.chromium.org/1947763002/

BUG=608873
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-11-17 07:06:50]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 07:07:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kai Ninomiya, 2016-11-17 07:10:29]

kainino@chromium.org changed reviewers:
+ kbr@chromium.org, zmo@chromium.org

[Kai Ninomiya, 2016-11-17 07:10:30]

low priority, but PTAL

[commit-bot: I haz the power, 2016-11-17 08:44:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 08:44:32]

Dry run: This issue passed the CQ dry run.

[Ken Russell (switch to Gerrit), 2016-11-29 04:31:17]

Thanks for revisiting this and sorry for the very slow review.

LGTM -- do you think you could run some before-and-after tests of the pure WebGL
version of the demo from https://github.com/mtrofin/wasm-android-demo
(webGL/webgl-teapots.htm) on Android and see whether this delivers a measurable
speed increase?

https://codereview.chromium.org/2510583004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/2510583004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:1337: if
(!drawingBuffer()->markContentsChanged() && m_markedCanvasDirty) {
We should really revisit and clean up the maintenance of m_markedCanvasDirty,
which seems to only be set to false on the software compositing path.

[Kai Ninomiya, 2016-11-30 01:50:33]

On 2016/11/29 04:31:17, Ken Russell wrote:
> Thanks for revisiting this and sorry for the very slow review.
> 
> LGTM -- do you think you could run some before-and-after tests of the pure
WebGL
> version of the demo from https://github.com/mtrofin/wasm-android-demo
> (webGL/webgl-teapots.htm) on Android and see whether this delivers a
measurable
> speed increase?

Didn't see any changes, as mentioned here https://crbug.com/608873#c9

[Ken Russell (switch to Gerrit), 2016-11-30 01:51:57]

On 2016/11/30 01:50:33, Kai Ninomiya wrote:
> On 2016/11/29 04:31:17, Ken Russell wrote:
> > Thanks for revisiting this and sorry for the very slow review.
> > 
> > LGTM -- do you think you could run some before-and-after tests of the pure
> WebGL
> > version of the demo from https://github.com/mtrofin/wasm-android-demo
> > (webGL/webgl-teapots.htm) on Android and see whether this delivers a
> measurable
> > speed increase?
> 
> Didn't see any changes, as mentioned here https://crbug.com/608873#c9

Thanks for testing. Please feel free to CQ.

[Kai Ninomiya, 2016-11-30 04:31:30]

The CQ bit was checked by kainino@chromium.org

[Kai Ninomiya, 2016-11-30 04:32:03]

The CQ bit was unchecked by kainino@chromium.org

[Kai Ninomiya, 2016-11-30 17:33:00]

The CQ bit was checked by kainino@chromium.org

[commit-bot: I haz the power, 2016-11-30 17:33:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 19:44:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480527180847900,
"parent_rev": "60f36392208d618374ccfdf16baff28af58b8853", "commit_rev":
"dbf6e115ce0ca1c345df648ae05b181390005996"}

[commit-bot: I haz the power, 2016-11-30 19:45:17]

Description was changed from

==========
Early terminate WebGL markContextChanged calls when appropriate

Slightly modified version of bajones's patch at:
https://codereview.chromium.org/1947763002/

BUG=608873
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Early terminate WebGL markContextChanged calls when appropriate

Slightly modified version of bajones's patch at:
https://codereview.chromium.org/1947763002/

BUG=608873
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-30 19:45:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-30 19:49:50]

Description was changed from

==========
Early terminate WebGL markContextChanged calls when appropriate

Slightly modified version of bajones's patch at:
https://codereview.chromium.org/1947763002/

BUG=608873
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Early terminate WebGL markContextChanged calls when appropriate

Slightly modified version of bajones's patch at:
https://codereview.chromium.org/1947763002/

BUG=608873
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/84361b5e33d34f6075aa2cdf13e3f6301903571f
Cr-Commit-Position: refs/heads/master@{#435380}
==========

[commit-bot: I haz the power, 2016-11-30 19:49:51]

Patchset 2 (id:??) landed as
https://crrev.com/84361b5e33d34f6075aa2cdf13e3f6301903571f
Cr-Commit-Position: refs/heads/master@{#435380}