Chromium Code Reviews
DescriptionFix TextInputClientMac related crashes of Fullscreen RenderWidget.
TextInputClientObsever should skip commands from fullscreen RenderWidgetHosts corresponding to plugins.
TextInputClientObserver assumes that the RenderWidget::GetWebWidget() always
returns a WebFrameWidget.
This is not true when the RenderWidget is a RenderWidgetFullScreen. Therefore,
pressing Ctrl+Command+D
on a fullscreen flash will lead to a DCHECK firing in dev builds as well as
crashes in current Canary.
This CL will avoid sending any IPCs from TextInputClientMac to the fullscreen
RenderWidget.
BUG=656525, 663384
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2422973003
Cr-Commit-Position: refs/heads/master@{#430842}
(cherry picked from commit aeb3c5c70a6ab7472e802d424c9c4a628e819283)
Patch Set 1 #
Messages
Total messages: 9 (4 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||