Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 2510573002: Fix TextInputClientMac related crashes of Fullscreen RenderWidget (Closed)

Created:
4 years, 1 month ago by EhsanK
Modified:
4 years, 1 month ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Fix TextInputClientMac related crashes of Fullscreen RenderWidget. TextInputClientObsever should skip commands from fullscreen RenderWidgetHosts corresponding to plugins. TextInputClientObserver assumes that the RenderWidget::GetWebWidget() always returns a WebFrameWidget. This is not true when the RenderWidget is a RenderWidgetFullScreen. Therefore, pressing Ctrl+Command+D on a fullscreen flash will lead to a DCHECK firing in dev builds as well as crashes in current Canary. This CL will avoid sending any IPCs from TextInputClientMac to the fullscreen RenderWidget. BUG=656525, 663384 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2422973003 Cr-Commit-Position: refs/heads/master@{#430842} (cherry picked from commit aeb3c5c70a6ab7472e802d424c9c4a628e819283)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -12 lines) Patch
M content/browser/renderer_host/render_widget_host_delegate.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/text_input_client_mac.mm View 5 chunks +36 lines, -8 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
EhsanK
Avi, Could you please take a quick look for sanity check? Thanks!
4 years, 1 month ago (2016-11-16 07:06:44 UTC) #3
Avi (use Gerrit)
lgtm for your cherrypick.
4 years, 1 month ago (2016-11-16 15:28:41 UTC) #4
EhsanK
Thanks Avi. Tested locally and things seem green. Trying CQ.
4 years, 1 month ago (2016-11-16 21:35:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510573002/1
4 years, 1 month ago (2016-11-16 21:36:37 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 21:41:37 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698