Issue 251054: Attempt 4 at fixing font size on linux. I think I finally got...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 251054: Attempt 4 at fixing font size on linux. I think I finally got... (Closed)

Created:
11 years, 2 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Attempt 4 at fixing font size on linux. I think I finally got it. Pango scales all font sizes by a factor. Scaling the font size, then asking skia for the metrics gives us exactly the same sizes as Pango. WAHOO! BUG=22791 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27725

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -16 lines)			Patch
	M	app/gfx/font_skia.cc	View	1 2	4 chunks	+27 lines, -13 lines	0 comments	Download
	M	app/gfx/font_unittest.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages