Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2510523002: Assign "application/vnd.android.package-archive" type to APK files on ChromeOS. (Closed)

Created:
4 years, 1 month ago by kinaba
Modified:
3 years, 3 months ago
Reviewers:
asanka, cbsamsamsam
CC:
extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Assign "application/vnd.android.package-archive" type to APK files on ChromeOS. The type is necessary for passing the control correctly to the Android side. BUG=665703 BUG=b/32772663 Committed: https://crrev.com/f9cdf760c1481c78875f079690821f35a09c8e1f Cr-Commit-Position: refs/heads/master@{#432707}

Patch Set 1 #

Patch Set 2 : Test #

Total comments: 2

Patch Set 3 : Assign "application/vnd.android.package-archive" type to APK files on ChromeOS. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M net/base/mime_extension_chromeos.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/mime_util_unittest.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
kinaba
PTAL: asanka@
4 years, 1 month ago (2016-11-16 05:13:53 UTC) #6
asanka
lgtm https://codereview.chromium.org/2510523002/diff/20001/net/base/mime_util_unittest.cc File net/base/mime_util_unittest.cc (right): https://codereview.chromium.org/2510523002/diff/20001/net/base/mime_util_unittest.cc#newcode34 net/base/mime_util_unittest.cc:34: {FILE_PATH_LITERAL("apk"), "application/vnd.android.package-archive", true}, Might as well add .zip ...
4 years, 1 month ago (2016-11-16 14:51:45 UTC) #7
kinaba
https://codereview.chromium.org/2510523002/diff/20001/net/base/mime_util_unittest.cc File net/base/mime_util_unittest.cc (right): https://codereview.chromium.org/2510523002/diff/20001/net/base/mime_util_unittest.cc#newcode34 net/base/mime_util_unittest.cc:34: {FILE_PATH_LITERAL("apk"), "application/vnd.android.package-archive", true}, On 2016/11/16 14:51:45, asanka wrote: > ...
4 years, 1 month ago (2016-11-17 00:16:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510523002/40001
4 years, 1 month ago (2016-11-17 00:17:06 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-17 02:30:03 UTC) #12
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/f9cdf760c1481c78875f079690821f35a09c8e1f Cr-Commit-Position: refs/heads/master@{#432707}
4 years, 1 month ago (2016-11-17 02:50:07 UTC) #14
cbsamsamsam
lgtm
3 years, 3 months ago (2017-08-24 21:10:53 UTC) #16
cbsamsamsam
3 years, 3 months ago (2017-08-24 21:11:45 UTC) #17
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698