Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2510513002:
Issue paint offset for SVGText, etc. (Closed)
DescriptionIssue paint offset for SVGText, etc.
Some SVG objects are painted by HTML painters which treat the SVG
objects as normal HTML objects about paint offsets. For these objects,
PaintPropertyTreeBuilder should issue the same paint offsets as used
in painting.
BUG=665259
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Committed: https://crrev.com/3015f7f3e90d4fa035de35348a02479ebd2bf318
Cr-Commit-Position: refs/heads/master@{#435435}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Rebase #
Messages
Total messages: 22 (14 generated)
Description was changed from ========== Issue paint offset for SVGText, etc. Some SVG objects are painted by HTML painters which treat the SVG objects as normal HTML objects about paint offsets. For these objects, PaintPropertyTreeBuilder should issue the same paint offsets as used in painting. BUG=665259 ========== to ========== Issue paint offset for SVGText, etc. Some SVG objects are painted by HTML painters which treat the SVG objects as normal HTML objects about paint offsets. For these objects, PaintPropertyTreeBuilder should issue the same paint offsets as used in painting. BUG=665259 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
wangxianzhu@chromium.org changed reviewers: + pdr@chromium.org
Nice! LGTM https://codereview.chromium.org/2510513002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/paint/ObjectPainter.cpp (right): https://codereview.chromium.org/2510513002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/paint/ObjectPainter.cpp:712: << " from PaintPropertyTreeBulder: " Nit: Builder https://codereview.chromium.org/2510513002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp (right): https://codereview.chromium.org/2510513002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:862: // The following condition also includes any SVG objects inheriting LayoutBox Nit: ...inheriting [from] LayoutBox...
https://codereview.chromium.org/2510513002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/paint/ObjectPainter.cpp (right): https://codereview.chromium.org/2510513002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/paint/ObjectPainter.cpp:712: << " from PaintPropertyTreeBulder: " On 2016/11/16 03:53:49, pdr. wrote: > Nit: Builder Done. https://codereview.chromium.org/2510513002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp (right): https://codereview.chromium.org/2510513002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:862: // The following condition also includes any SVG objects inheriting LayoutBox On 2016/11/16 03:53:49, pdr. wrote: > Nit: ...inheriting [from] LayoutBox... Done.
The CQ bit was unchecked by wangxianzhu@chromium.org
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by wangxianzhu@chromium.org
The CQ bit was checked by wangxianzhu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org Link to the patchset: https://codereview.chromium.org/2510513002/#ps20001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480541424196890,
"parent_rev": "62dd58c334bff5be7ece23574f16ed4d25242678", "commit_rev":
"b1e9d5b4109e87cee939d07751379660ecefb4ab"}
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Issue paint offset for SVGText, etc. Some SVG objects are painted by HTML painters which treat the SVG objects as normal HTML objects about paint offsets. For these objects, PaintPropertyTreeBuilder should issue the same paint offsets as used in painting. BUG=665259 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Issue paint offset for SVGText, etc. Some SVG objects are painted by HTML painters which treat the SVG objects as normal HTML objects about paint offsets. For these objects, PaintPropertyTreeBuilder should issue the same paint offsets as used in painting. BUG=665259 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/3015f7f3e90d4fa035de35348a02479ebd2bf318 Cr-Commit-Position: refs/heads/master@{#435435} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3015f7f3e90d4fa035de35348a02479ebd2bf318 Cr-Commit-Position: refs/heads/master@{#435435} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
