Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 251051: Move various methods from glue/webview.h to api/public/WebView.h... (Closed)

Created:
11 years, 2 months ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
dglazkov
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, jam, pam+watch_chromium.org, Paweł Hajdan Jr., darin (slow to review), tim (not reviewing)
Visibility:
Public.

Description

Move various methods from glue/webview.h to api/public/WebView.h I'll re-order the methods in webview_impl.cc in a follow-up CL. I wanted to keep this one easy to review. SetBackForwardListSize is no longer necessary given that BackForwardListChromium.cpp doesn't care about its capacity. R=dglazkov BUG=10033 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27705

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -155 lines) Patch
M chrome/renderer/print_web_view_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/render_view.cc View 7 chunks +9 lines, -14 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/api/public/WebView.h View 4 chunks +35 lines, -1 line 0 comments Download
M webkit/glue/chrome_client_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/mimetype_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webframe_impl.cc View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M webkit/glue/webpreferences.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webview.h View 3 chunks +0 lines, -52 lines 0 comments Download
M webkit/glue/webview_impl.h View 3 chunks +10 lines, -21 lines 0 comments Download
M webkit/glue/webview_impl.cc View 9 chunks +14 lines, -38 lines 0 comments Download
M webkit/glue/webview_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M webkit/glue/webworker_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/layout_test_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/mac/test_shell_webview.mm View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/mac/webview_host.mm View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/webview_host_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/webview_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
darin (slow to review)
11 years, 2 months ago (2009-09-30 23:23:15 UTC) #1
dglazkov
LGTM, with comments: http://codereview.chromium.org/251051/diff/1/17 File chrome/renderer/render_view.cc (left): http://codereview.chromium.org/251051/diff/1/17#oldcode324 Line 324: webview()->SetBackForwardListSize(1); Did you forget to ...
11 years, 2 months ago (2009-09-30 23:28:32 UTC) #2
darin (slow to review)
11 years, 2 months ago (2009-09-30 23:46:52 UTC) #3
http://codereview.chromium.org/251051/diff/1/17
File chrome/renderer/render_view.cc (left):

http://codereview.chromium.org/251051/diff/1/17#oldcode324
Line 324: webview()->SetBackForwardListSize(1);
On 2009/09/30 23:28:32, Dimitri Glazkov wrote:
> Did you forget to add this back somewhere? Or is this initialized elsewhere?

It is not needed anymore.  It was important when we were using the same
implementation of BackForwardList.cpp as other WebKit ports.  Now, it doesn't
matter, so I killed it.  I will update the CL description to mention this.

Powered by Google App Engine
This is Rietveld 408576698