Source/core/html/parser/HTMLSrcsetParser.h - Issue 25105004: Use srcset's resource pixel density to determine intrinsic size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/parser/HTMLSrcsetParser.h

Issue 25105004: Use srcset's resource pixel density to determine intrinsic size (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cleantests

Patch Set: Fixed expected test results Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/canvas/CanvasRenderingContext2D.cpp ('K') | « Source/core/html/canvas/CanvasRenderingContext2D.cpp ('k') | Source/core/html/parser/HTMLSrcsetParser.cpp » ('j') | Source/core/html/parser/HTMLSrcsetParser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/parser/HTMLSrcsetParser.h

diff --git a/Source/core/html/parser/HTMLSrcsetParser.h b/Source/core/html/parser/HTMLSrcsetParser.h

index bb53cb893c90f0ed051243083120043e7ec5994d..fe8266e7cc43399ed9b49640db1f24ae259069a6 100644

--- a/Source/core/html/parser/HTMLSrcsetParser.h

+++ b/Source/core/html/parser/HTMLSrcsetParser.h

@@ -70,7 +70,7 @@ private:

ImageCandidate bestFitSourceForSrcsetAttribute(float deviceScaleFactor, const String& srcsetAttribute);

-String bestFitSourceForImageAttributes(float deviceScaleFactor, const String& srcAttribute, const String& srcsetAttribute);

+String bestFitSourceForImageAttributes(float deviceScaleFactor, const String& srcAttribute, const String& srcsetAttribute, float& scaleFactor);

pdr. 2013/10/11 05:17:33 This is a little confusing because the function re

Yoav Weiss 2013/10/11 07:22:32 OK.

String bestFitSourceForImageAttributes(float deviceScaleFactor, const String& srcAttribute, ImageCandidate& srcsetImageCandidate);