LayoutTests/fast/hidpi/image-srcset-change-resource-dpr.html - Issue 25105004: Use srcset's resource pixel density to determine intrinsic size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/hidpi/image-srcset-change-resource-dpr.html

Issue 25105004: Use srcset's resource pixel density to determine intrinsic size (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cleantests

Patch Set: Fixed crash+rebased Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x-expected.txt ('k') | LayoutTests/fast/hidpi/image-srcset-change-resource-dpr-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/hidpi/image-srcset-change-resource-dpr.html

diff --git a/LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x.html b/LayoutTests/fast/hidpi/image-srcset-change-resource-dpr.html

similarity index 52%

copy from LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x.html

copy to LayoutTests/fast/hidpi/image-srcset-change-resource-dpr.html

index b6ff47540e40a731af2f75d349558c160a71853a..3d230e560a9d69e3503b76b74a967d6cdc166476 100644

--- a/LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x.html

+++ b/LayoutTests/fast/hidpi/image-srcset-change-resource-dpr.html

@@ -1,26 +1,22 @@

<html>

<head>

+<script>

+ if (window.testRunner)

+ testRunner.waitUntilDone();

+ window.manualNotifyDone = true;

+</script>

- if (window.testRunner) {

- testRunner.dumpAsText();

- }

- function updateSrc() {

+ addEventListener("load", function() {

var img = document.getElementById("foo");

- // srcset must be set first, otherwise 'src' is loaded as well

img.srcset = "resources/green-200-px-square.png 2x";

- img.src = "resources/blue-100-px-square.png"

- }

- addEventListener("DOMContentLoaded", function() {

- updateSrc();

- }, false);

- addEventListener("load", function() {

- if (internals)

- shouldBeFalse('internals.isPreloaded("resources/blue-100-px-square.png")');

- shouldBeTrue('document.getElementById("foo").clientWidth==200');

+ img.addEventListener("load", function() {

+ shouldBeTrue('document.getElementById("foo").clientWidth==200');

+ shouldBeFalse('document.getElementById("foo").clientWidth==400');

+ if (window.testRunner)

+ testRunner.notifyDone();

+ }, false);

}, false);

</script>

</head>

@@ -28,6 +24,6 @@

<div>This test passes if this img tag below is a green square when the scale factor is 2.

It ensures that attributes can be changed dynamically from javascript, and that only the correct resource is loaded.</div>

- <img id="foo">

+ <img id="foo" src="resources/blue-100-px-square.png">

</body>

</html>