LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x-expected.txt - Issue 25105004: Use srcset's resource pixel density to determine intrinsic size

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x-expected.txt

Issue 25105004: Use srcset's resource pixel density to determine intrinsic size (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cleantests

Patch Set: Fixed expected test results Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/TestExpectations ('K') | « LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x.html ('k') | LayoutTests/fast/hidpi/image-srcset-data-src.html » ('j') | Source/core/html/HTMLImageElement.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 PASS internals.isPreloaded("resources/blue-100-px-square.png") is false	1 main frame - script requested 'srcset-helper.js'

	2 main frame - script requested 'js-test-pre.js'

	3 main frame - script requested 'js-test-pre.js'

	4 main frame - img requested 'green-200-px-square.png'

	5 main frame - img requested 'blue-100-px-square.png'
	pdr. 2013/10/11 05:17:33 Why is blue-100-px-square.png loaded here? Why is blue-100-px-square.png loaded here? Yoav Weiss 2013/10/11 07:22:32 The page is loaded twice, where the first load set Show quoted text On 2013/10/11 05:17:33, pdr wrote: > Why is blue-100-px-square.png loaded here? The page is loaded twice, where the first load set the deviceScaleFactor to 2 and then reloads. (That the standard hack to change the deviceScaleFactor. Therefore, the first load has a deviceScaleFactor of 1, and loads the 1x resources. But, I guess the interesting question is why is green-200-px-square.png requested on the first page load. That looks like a bug in the srcset implementation! (Not really related to this CL) I'll file one.
	6 main frame - document requested 'image-srcset-change-dynamically-from-js-2x.html '

	7 main frame - script requested 'srcset-helper.js'

	8 main frame - script requested 'js-test-pre.js'

	9 main frame - script requested 'js-test-pre.js'

	10 main frame - img requested 'green-200-px-square.png'

	11 main frame - img requested 'green-200-px-square.png'

2 PASS document.getElementById("foo").clientWidth==200 is true	12 PASS document.getElementById("foo").clientWidth==200 is true

3 This test passes if this img tag below is a green square when the scale factor i s 2. It ensures that attributes can be changed dynamically from javascript, and that only the correct resource is loaded.	13 This test passes if this img tag below is a green square when the scale factor i s 2. It ensures that attributes can be changed dynamically from javascript, and that only the correct resource is loaded.

4	14

OLD	NEW