Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1962)

Unified Diff: ash/root_window_controller.cc

Issue 25105002: Deletes keyboard container before recreating the controller. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added unit test for bug. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/root_window_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/root_window_controller.cc
diff --git a/ash/root_window_controller.cc b/ash/root_window_controller.cc
index 3b36a710965dc96bd43d78c610f0cb55e440cc7e..9327cbd077a5b7b0aa8063d75099723fbf1ad7b9 100644
--- a/ash/root_window_controller.cc
+++ b/ash/root_window_controller.cc
@@ -531,6 +531,10 @@ void RootWindowController::InitKeyboard() {
keyboard_controller_->AddObserver(shelf()->shelf_layout_manager());
keyboard_controller_->AddObserver(panel_layout_manager_);
+ // Deletes the old container since |keyboard_controller_| creates a
+ // new container window in GetContainerWindow().
+ delete GetContainer(kShellWindowId_VirtualKeyboardContainer);
+
aura::Window* keyboard_container =
keyboard_controller_->GetContainerWindow();
keyboard_container->set_id(kShellWindowId_VirtualKeyboardContainer);
« no previous file with comments | « no previous file | ash/root_window_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698