Timeline: add support for jumping to frame for aggregated trees

third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /**
  * @unrestricted
  */
 Timeline.TimelineTreeView = class extends UI.VBox {
   constructor() {
     super();
     this.element.classList.add('timeline-tree-view');
@@ skipping 23 matching lines @@
 
     var columns = /** @type {!Array<!UI.DataGrid.ColumnDescriptor>} */ ([]);
     this._populateColumns(columns);
 
     var mainView = new UI.VBox();
     this._populateToolbar(mainView.element);
     this._dataGrid = new UI.SortableDataGrid(columns);
     this._dataGrid.addEventListener(UI.DataGrid.Events.SortingChanged, this._sortingChanged, this);
     this._dataGrid.element.addEventListener('mousemove', this._onMouseMove.bind(this), true);
     this._dataGrid.setResizeMethod(UI.DataGrid.ResizeMethod.Last);
+    this._dataGrid.setRowContextMenuCallback(this._onContextMenu.bind(this));
     this._dataGrid.asWidget().show(mainView.element);
 
     this._splitWidget = new UI.SplitWidget(true, true, 'timelineTreeViewDetailsSplitWidget');
     this._splitWidget.show(this.element);
     this._splitWidget.setMainWidget(mainView);
 
     this._detailsView = new UI.VBox();
     this._detailsView.element.classList.add('timeline-details-view', 'timeline-details-view-body');
     this._splitWidget.setSidebarWidget(this._detailsView);
     this._dataGrid.addEventListener(UI.DataGrid.Events.SelectedNode, this._updateDetailsForSelection, this);
@@ skipping 32 matching lines @@
   _populateToolbar(parent) {
   }
 
   /**
    * @param {?TimelineModel.TimelineProfileTree.Node} node
    */
   _onHover(node) {
   }
 
   /**
+   * @param {!UI.ContextMenu} contextMenu
+   * @param {!TimelineModel.TimelineProfileTree.Node} node
+   */
+  _appendContextMenuItems(contextMenu, node) {

[alph, 2016/11/16 02:29:21]

We do not start protected functions with _. don't we?

+  }
+
+  /**
    * @param {!SDK.TracingModel.Event} event
    * @return {?Element}
    */
   _linkifyLocation(event) {
     var target = this._model.targetByEvent(event);
     if (!target)
       return null;
     var frame = TimelineModel.TimelineProfileTree.eventStackFrame(event);
     if (!frame)
       return null;
@@ skipping 159 matching lines @@
             this._dataGrid.dataGridNodeFromNode(/** @type {!Node} */ (event.target))) :
         null;
     var profileNode = gridNode && gridNode._profileNode;
     if (profileNode === this._lastHoveredProfileNode)
       return;
     this._lastHoveredProfileNode = profileNode;
     this._onHover(profileNode);
   }
 
   /**
+   * @param {!UI.ContextMenu} contextMenu
+   * @param {!UI.DataGridNode} gridNode
+   */
+  _onContextMenu(contextMenu, gridNode) {
+    var profileNode = gridNode._profileNode;
+    if (!profileNode)
+      return;
+    this._appendContextMenuItems(contextMenu, profileNode);
+  }
+
+  /**
    * @param {!TimelineModel.TimelineProfileTree.Node} treeNode
    * @return {?Timeline.TimelineTreeView.GridNode}
    */
   _dataGridNodeForTreeNode(treeNode) {
     return treeNode[Timeline.TimelineTreeView.TreeGridNode._gridNodeSymbol] || null;
   }
 };
 
 
 /**
@@ skipping 358 matching lines @@
         return groupByDomain.bind(null, true);
       case Timeline.AggregatedTimelineTreeView.GroupBy.URL:
         return groupByURL;
       case Timeline.AggregatedTimelineTreeView.GroupBy.Frame:
         return event => TimelineModel.TimelineData.forEvent(event).frameId;
       default:
         console.assert(false, `Unexpected aggregation setting: ${groupBy}`);
         return () => Symbol('uniqueGroupId');
     }
   }
+  /**
+   * @override
+   * @param {!UI.ContextMenu} contextMenu
+   * @param {!TimelineModel.TimelineProfileTree.Node} node
+   */
+  _appendContextMenuItems(contextMenu, node) {
+    if (this._groupBySetting.get() !== Timeline.AggregatedTimelineTreeView.GroupBy.Frame)
+      return;
+    if (!node.isGroupNode())
+      return;
+    var frame = this._model.pageFrameById(node.id);
+    if (!frame || !frame.ownerNode)
+      return;
+    contextMenu.appendApplicableItems(frame.ownerNode);
+  }
 
   /**
    * @param {string} url
    * @return {boolean}
    */
   static _isExtensionInternalURL(url) {
     return url.startsWith(Timeline.AggregatedTimelineTreeView._extensionInternalPrefix);
   }
 };
 
@@ skipping 241 matching lines @@
 
   _onSelectionChanged() {
     this.dispatchEventToListeners(Timeline.TimelineStackView.Events.SelectionChanged);
   }
 };
 
 /** @enum {symbol} */
 Timeline.TimelineStackView.Events = {
   SelectionChanged: Symbol('SelectionChanged')
 };