Timeline: add support for jumping to frame for aggregated trees

Timeline: add support for jumping to frame for aggregated trees

This adds a context menu item for group tree nodes in a
TimelineTreeView to reveal the related frame in the Elements
panel, provided the grouping is by frame.

BUG=662990
Committed: https://crrev.com/506586367b7a3b51201870bf86da6d5375755090
Cr-Commit-Position: refs/heads/master@{#432561}

[caseq, 2016-11-16 01:54:49]

caseq@chromium.org changed reviewers:
+ alph@chromium.org, dgozman@chromium.org

[caseq, 2016-11-16 02:08:20]

Reverted stray change, ptal.

[alph, 2016-11-16 02:29:21]

https://codereview.chromium.org/2510493002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
(right):

https://codereview.chromium.org/2510493002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js:100:
_appendContextMenuItems(contextMenu, node) {
We do not start protected functions with _. don't we?

[caseq, 2016-11-16 02:30:19]

On 2016/11/16 02:29:21, alph wrote:
>
https://codereview.chromium.org/2510493002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
> (right):
> 
>
https://codereview.chromium.org/2510493002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js:100:
> _appendContextMenuItems(contextMenu, node) {
> We do not start protected functions with _. don't we?

Right, this is file-private :-)

[alph, 2016-11-16 02:30:24]

lgtm

[caseq, 2016-11-16 02:30:36]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2016-11-16 02:31:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 04:04:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 04:04:33]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[caseq, 2016-11-16 17:08:13]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2016-11-16 17:09:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 18:24:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-16 18:52:31]

Description was changed from

==========
Timeline: add support for jumping to frame for aggregated trees

This adds a context menu item for group tree nodes in a
TimelineTreeView to reveal the related frame in the Elements
panel, provided the grouping is by frame.

BUG=662990
==========

to

==========
Timeline: add support for jumping to frame for aggregated trees

This adds a context menu item for group tree nodes in a
TimelineTreeView to reveal the related frame in the Elements
panel, provided the grouping is by frame.

BUG=662990

Committed: https://crrev.com/506586367b7a3b51201870bf86da6d5375755090
Cr-Commit-Position: refs/heads/master@{#432561}
==========

[commit-bot: I haz the power, 2016-11-16 18:52:32]

Patchset 2 (id:??) landed as
https://crrev.com/506586367b7a3b51201870bf86da6d5375755090
Cr-Commit-Position: refs/heads/master@{#432561}