Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 251047: Tag Mac VM regions allocated by V8. This has no effect other than making it possi... (Closed)

Created:
11 years, 2 months ago by Jens Alfke
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Tag Mac OS X VM regions allocated by V8. This has no effect other than making it possible to identify V8 allocations in the vmmap(1) memory profiling tool, to get a better idea of Chrome's memory usage. BUG=23455 TEST=Tested by running vmmap(1) and looking for "Memory tag=255" and "Memory tag=254" in the output.

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M src/platform-macos.cc View 1 6 chunks +19 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jens Alfke
11 years, 2 months ago (2009-09-30 20:32:15 UTC) #1
iposva
11 years, 2 months ago (2009-09-30 21:09:50 UTC) #2
Jens,

LGTM over all. I will take your patch and apply the minimal change to
V8-bleeding_edge in a new change list.

-Ivan

Powered by Google App Engine
This is Rietveld 408576698