Issue 251047: Tag Mac VM regions allocated by V8. This has no effect other than making it possi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 251047: Tag Mac VM regions allocated by V8. This has no effect other than making it possi... (Closed)

Created:
11 years, 2 months ago by Jens Alfke

Modified:
9 years, 7 months ago

Reviewers:
iposva, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/tags/1.3.12/

Visibility:
Public.

Description

Tag Mac OS X VM regions allocated by V8. This has no effect other than making it possible to identify V8 allocations in the vmmap(1) memory profiling tool, to get a better idea of Chrome's memory usage. BUG=23455 TEST=Tested by running vmmap(1) and looking for "Memory tag=255" and "Memory tag=254" in the output.

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -8 lines)			Patch
	M	src/platform-macos.cc	View	1	6 chunks	+19 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

iposva

11 years, 2 months ago (2009-09-30 21:09:50 UTC) #2

Jens,

LGTM over all. I will take your patch and apply the minimal change to
V8-bleeding_edge in a new change list.

-Ivan

Expand Messages | Collapse Messages