[Cronet] Retain block passed to setRequestFilterBlock on iOS.

components/cronet/ios/test/cronet_http_test.mm

Index: components/cronet/ios/test/cronet_http_test.mm
diff --git a/components/cronet/ios/test/cronet_http_test.mm b/components/cronet/ios/test/cronet_http_test.mm
index 89e64a2422d9b01f83fcc0154ca2b68784ad1062..eff3ea976bbe105e23699272dd05627a9e6d935e 100644
--- a/components/cronet/ios/test/cronet_http_test.mm
+++ b/components/cronet/ios/test/cronet_http_test.mm
@@ -122,7 +122,11 @@ class HttpTest : public ::testing::Test {
     grpc_support::StartQuicTestServer();
     TestServer::Start();
 
+    [Cronet setRequestFilterBlock:^(NSURLRequest* request) {
+      return YES;
+    }];
     StartCronetIfNecessary(grpc_support::GetQuicTestServerPort());
+    [Cronet registerHttpProtocolHandler];
     NSURLSessionConfiguration* config =
         [NSURLSessionConfiguration ephemeralSessionConfiguration];
     [Cronet installIntoSessionConfiguration:config];
@@ -155,8 +159,15 @@ class HttpTest : public ::testing::Test {
 
 TEST_F(HttpTest, NSURLSessionReceivesData) {
   NSURL* url = net::NSURLWithGURL(GURL(grpc_support::kTestServerUrl));
+  __block BOOL block_used = NO;
   NSURLSessionDataTask* task = [session_ dataTaskWithURL:url];
+  [Cronet setRequestFilterBlock:^(NSURLRequest* request) {
+    block_used = YES;
+    EXPECT_EQ([request URL], url);
+    return YES;
+  }];
   StartDataTaskAndWaitForCompletion(task);
+  EXPECT_TRUE(block_used);
   EXPECT_EQ(nil, [delegate_ error]);
   EXPECT_STREQ(grpc_support::kHelloBodyValue,
                base::SysNSStringToUTF8([delegate_ responseBody]).c_str());
@@ -197,10 +208,29 @@ TEST_F(HttpTest, NSURLSessionAcceptLanguage) {
 TEST_F(HttpTest, SetUserAgentIsExact) {
   NSURL* url =
       net::NSURLWithGURL(GURL(TestServer::GetEchoHeaderURL("User-Agent")));
+  [Cronet setRequestFilterBlock:nil];
   NSURLSessionDataTask* task = [session_ dataTaskWithURL:url];
   StartDataTaskAndWaitForCompletion(task);
   EXPECT_EQ(nil, [delegate_ error]);
   EXPECT_STREQ(kUserAgent, [[delegate_ responseBody] UTF8String]);
 }
 
+TEST_F(HttpTest, FilterOutRequest) {
+  NSURL* url =
+      net::NSURLWithGURL(GURL(TestServer::GetEchoHeaderURL("User-Agent")));
+  __block BOOL block_used = NO;
+  NSURLSessionDataTask* task = [session_ dataTaskWithURL:url];
+  [Cronet setRequestFilterBlock:^(NSURLRequest* request) {
+    block_used = YES;
+    EXPECT_EQ([request URL], url);
+    return NO;
+  }];
+  StartDataTaskAndWaitForCompletion(task);
+  EXPECT_TRUE(block_used);
+  EXPECT_EQ(nil, [delegate_ error]);
+  EXPECT_STRNE(kUserAgent,

[kapishnikov, 2016/11/16 17:58:53]

nit: We can make this assert stronger by using 'containsString' instead of
strict equality. It is just in case if in the future we prepend something to
kUserAgent by mistake. Something like:

EXPECT_FALSE([[delegate_ responseBody] containsString:[NSString   
stringWithCString:kUserAgent ...]);

[mef, 2016/11/16 18:11:11]

Done.

+               base::SysNSStringToUTF8([delegate_ responseBody]).c_str());
+  EXPECT_TRUE([[delegate_ responseBody] containsString:@"CFNetwork"]);
+}
+
 }  // namespace cronet