Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: tools/perf/page_sets/system_health/browsing_stories.py

Issue 2510443002: [System Health] Change scrolling behaviour for news sites. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/system_health/browsing_stories.py
diff --git a/tools/perf/page_sets/system_health/browsing_stories.py b/tools/perf/page_sets/system_health/browsing_stories.py
index ef283c7d2088283069b3b6f0324b8a77e93a0d0d..e0753eac5e45faa94a841248a35aa9f98f5ca1e2 100644
--- a/tools/perf/page_sets/system_health/browsing_stories.py
+++ b/tools/perf/page_sets/system_health/browsing_stories.py
@@ -76,9 +76,10 @@ class _NewsBrowsingStory(_BrowsingStory):
def _ReadNewsItem(self, action_runner):
action_runner.tab.WaitForDocumentReadyStateToBeComplete()
- action_runner.Wait(self.ITEM_READ_TIME_IN_SECONDS)
+ action_runner.Wait(self.ITEM_READ_TIME_IN_SECONDS/2)
rnephew (Reviews Here) 2016/11/15 22:08:43 We could also have it wait the entire time before
perezju 2016/11/16 09:58:05 Note: This is doing integer division. So before it
action_runner.RepeatableBrowserDrivenScroll(
repeat_count=self.ITEM_SCROLL_REPEAT)
+ action_runner.Wait(self.ITEM_READ_TIME_IN_SECONDS/2)
def _ScrollMainPage(self, action_runner):
action_runner.tab.WaitForDocumentReadyStateToBeComplete()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698