Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2510433002:
Roll build DEPS into PDFium (Closed)
DescriptionRoll build DEPS into PDFium
Rolling ToT build because we're currently sitting at a revision that
does not work in Mac.
Committed: https://pdfium.googlesource.com/pdfium/+/f35650c8778522345d8a639f42add2874ffe44dd
Patch Set 1 #Messages
Total messages: 20 (9 generated)
Description was changed from ========== Roll build DEPS into PDFium Rolling ToT build because we're currently sitting at a revision that does not work in Mac. ========== to ========== Roll build DEPS into PDFium Rolling ToT build because we're currently sitting at a revision that does not work in Mac. ==========
npm@chromium.org changed reviewers: + dsinclair@chromium.org, thestig@chromium.org
PTAL
The CQ bit was checked by npm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
npm@chromium.org changed reviewers: + dpranke@chromium.org
+Dirk Pranke, reviewer of last build roll
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
I can't tell what's broken. The main PDFium waterfall is green.
On 2016/11/15 22:57:42, Lei Zhang (not reviewing code) wrote: > I can't tell what's broken. The main PDFium waterfall is green. mac_sdk.gni is crashing when trying to gn args <DIR> It may be only broken for certain configurations. It's trying to open up an inexistent build/mac_files/Xcode.app directory.
LGTM Feel free to TBR if it's purely a DEPS roll.
The CQ bit was checked by npm@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/11/15 23:12:57, Lei Zhang (not reviewing code) wrote: > LGTM > > Feel free to TBR if it's purely a DEPS roll. That is, next time...
Message was sent while issue was closed.
Description was changed from ========== Roll build DEPS into PDFium Rolling ToT build because we're currently sitting at a revision that does not work in Mac. ========== to ========== Roll build DEPS into PDFium Rolling ToT build because we're currently sitting at a revision that does not work in Mac. Committed: https://pdfium.googlesource.com/pdfium/+/f35650c8778522345d8a639f42add2874ffe... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/f35650c8778522345d8a639f42add2874ffe...
Message was sent while issue was closed.
lgtm. I'm guessing you hit a hermetic mac toolchain issue? I can look at the failures if someone sends me links.
Message was sent while issue was closed.
On 2016/11/15 23:55:50, Dirk Pranke wrote:
> lgtm. I'm guessing you hit a hermetic mac toolchain issue?
>
> I can look at the failures if someone sends me links.
I don't have links because the bots are fine, but our machines are broken. This
is the error that I get when I try to gn args on a clean top of trunk pdfium on
my Mac (Dan is also getting this error):
ERROR at //build/config/mac/mac_sdk.gni:61:5: Script returned non-zero exit
code.
exec_script("//build/mac/find_sdk.py", find_sdk_args, "list lines")
^----------
Current dir: /Users/npm/pdfium/pdfium/out/Debug/
Command: python -- /Users/npm/pdfium/pdfium/build/mac/find_sdk.py
--print_sdk_path --developer_dir
/Users/npm/pdfium/pdfium/build/mac_files/Xcode.app 10.10
Returned 1.
stderr:
Traceback (most recent call last):
File "/Users/npm/pdfium/pdfium/build/mac/find_sdk.py", line 89, in <module>
print main()
File "/Users/npm/pdfium/pdfium/build/mac/find_sdk.py", line 57, in main
sdks = [re.findall('^MacOSX(10\.\d+)\.sdk$', s) for s in
os.listdir(sdk_dir)]
OSError: [Errno 2] No such file or directory:
'/Users/npm/pdfium/pdfium/build/mac_files/Xcode.app/Platforms/MacOSX.platform/Developer/SDKs'
I should note that there is no build/mac_files directory.
Message was sent while issue was closed.
On 2016/11/15 23:55:50, Dirk Pranke wrote: > lgtm. I'm guessing you hit a hermetic mac toolchain issue? > > I can look at the failures if someone sends me links. And you're right about the root cause. If I point my build to right before this commit, gn works fine. https://chromium.googlesource.com/chromium/src/build/+/8b8efd25125f283f94bc59... |
