Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: src/objects.cc

Issue 251043008: TODO in Dictionary resolved. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index acd3949228c91810466f432bd4198d2a0db21d6a..475ffe646b00d1e0e8a322d0cb59b44c8f031c01 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -15776,10 +15776,9 @@ Handle<Derived> Dictionary<Derived, Shape, Key>::AtPut(
// Check whether the dictionary should be extended.
dictionary = EnsureCapacity(dictionary, 1, key);
-
- Handle<Object> k = Shape::AsHandle(dictionary->GetIsolate(), key);
- // TODO(ishell): Figure out if it is necessary to call AsHandle() here.
- USE(k);
+#ifdef DEBUG
+ USE(Shape::AsHandle(dictionary->GetIsolate(), key));
+#endif
PropertyDetails details = PropertyDetails(NONE, NORMAL, 0);
AddEntry(dictionary, key, value, details, dictionary->Hash(key));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698