Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 251043007: Move Window use counters from DOMWindow.cpp to Window.idl where possible (Closed)

Created:
6 years, 7 months ago by philipj_slow
Modified:
6 years, 7 months ago
CC:
blink-reviews, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Move Window use counters from DOMWindow.cpp to Window.idl where possible None of these are used internally, but even if they were it's better to measure at the bindings level to only measure Web-exposed usage. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172900

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -19 lines) Patch
M Source/core/frame/DOMWindow.cpp View 8 chunks +0 lines, -9 lines 0 comments Download
M Source/core/frame/Window.idl View 3 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
6 years, 7 months ago (2014-04-29 11:01:14 UTC) #1
Inactive
lgtm
6 years, 7 months ago (2014-04-29 13:08:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/251043007/1
6 years, 7 months ago (2014-04-29 13:08:32 UTC) #3
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 03:47:27 UTC) #4
Message was sent while issue was closed.
Change committed as 172900

Powered by Google App Engine
This is Rietveld 408576698