Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 2510423002: Reland of [NTP] Refresh download list when NTP is open. (Closed)

Created:
4 years, 1 month ago by vitaliii
Modified:
4 years, 1 month ago
CC:
agrieve+watch_chromium.org, chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of [NTP] Refresh download list when NTP is open. (patchset #1 id:1 of https://codereview.chromium.org/2511973005/ ) Reason for revert: I am going to solve the initial issue. Original issue's description: > Revert of [NTP] Refresh download list when NTP is open. (patchset #2 id:20001 of https://codereview.chromium.org/2508133004/ ) > > Reason for revert: > Broke tests. > See crbug.com/666744 > > Original issue's description: > > [NTP] Refresh download list when NTP is open. > > > > So that we do not show on new NTPs items which were removed bypassing Chrome. > > > > BUG=666262 > > > > Committed: https://crrev.com/a17ba56880d3431adc2626ee006f7f65e703c84d > > Cr-Commit-Position: refs/heads/master@{#433174} > > TBR=bauerb@chromium.org,markusheintz@chromium.org,vitaliii@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=666262 > > Committed: https://crrev.com/e259c656eefd44425e3075ccec88853b7ec5fef8 > Cr-Commit-Position: refs/heads/master@{#433195} BUG=666262 Committed: https://crrev.com/8db51905a4c2cb2f154cab9bc184691091996cfe Cr-Commit-Position: refs/heads/master@{#433210}

Patch Set 1 #

Patch Set 2 : fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 1 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
vitaliii
Created Reland of [NTP] Refresh download list when NTP is open.
4 years, 1 month ago (2016-11-18 15:18:50 UTC) #1
Bernhard Bauer
lgtm
4 years, 1 month ago (2016-11-18 15:32:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510423002/40001
4 years, 1 month ago (2016-11-18 15:36:07 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-11-18 15:58:54 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 16:00:34 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8db51905a4c2cb2f154cab9bc184691091996cfe
Cr-Commit-Position: refs/heads/master@{#433210}

Powered by Google App Engine
This is Rietveld 408576698