Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2510403002: [heap] Remove AdjustBytes test introduced in r41097. (Closed)

Created:
4 years, 1 month ago by ulan
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove AdjustBytes test introduced in r41097. The test is too fragile. NOTREECHECKS=true Committed: https://crrev.com/46a4156a8b42178b438e243701f1f1695cddcdc8 Cr-Commit-Position: refs/heads/master@{#41103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -34 lines) Patch
M test/cctest/heap/heap-tester.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/heap/test-spaces.cc View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
ulan
ptal
4 years, 1 month ago (2016-11-18 12:10:47 UTC) #2
Michael Lippautz
lgtm
4 years, 1 month ago (2016-11-18 12:12:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510403002/1
4 years, 1 month ago (2016-11-18 12:12:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510403002/1
4 years, 1 month ago (2016-11-18 12:52:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 12:54:39 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 12:55:05 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46a4156a8b42178b438e243701f1f1695cddcdc8
Cr-Commit-Position: refs/heads/master@{#41103}

Powered by Google App Engine
This is Rietveld 408576698