Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.h

Issue 2510353004: Deprecating AutoplayExperimentHelper (Closed)
Patch Set: cleaned up the layout code no longer used Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.h b/third_party/WebKit/Source/core/html/HTMLMediaElement.h
index a4aae0c4f202d3135d9832a01dc30e160b345ac3..9b608318c62829696d2fddbbd0f9baf8fec680fd 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.h
@@ -34,7 +34,6 @@
#include "core/dom/ActiveDOMObject.h"
#include "core/dom/ExceptionCode.h"
#include "core/events/GenericEventQueue.h"
-#include "core/html/AutoplayExperimentHelper.h"
#include "core/html/HTMLElement.h"
#include "core/html/track/TextTrack.h"
#include "platform/MIMETypeRegistry.h"
@@ -173,8 +172,7 @@ class CORE_EXPORT HTMLMediaElement : public HTMLElement,
TimeRanges* seekable() const;
bool ended() const;
bool autoplay() const;
- bool shouldAutoplay(
- const RecordMetricsBehavior = RecordMetricsBehavior::DoNotRecord);
+ bool shouldAutoplay();
bool loop() const;
void setLoop(bool);
ScriptPromise playForBindings(ScriptState*);
@@ -302,10 +300,6 @@ class CORE_EXPORT HTMLMediaElement : public HTMLElement,
void videoWillBeDrawnToCanvas() const;
- // Temporary callback for crbug.com/487345,402044
- void notifyPositionMayHaveChanged(const IntRect&);
- void updatePositionNotificationRegistration();
-
WebRemotePlaybackClient* remotePlaybackClient() {
return m_remotePlaybackClient;
}
@@ -332,8 +326,6 @@ class CORE_EXPORT HTMLMediaElement : public HTMLElement,
DisplayMode getDisplayMode() const { return m_displayMode; }
virtual void setDisplayMode(DisplayMode mode) { m_displayMode = mode; }
- void recordAutoplayMetric(AutoplayMetrics);
-
private:
void resetMediaPlayerAndMediaSource();
@@ -530,9 +522,6 @@ class CORE_EXPORT HTMLMediaElement : public HTMLElement,
void audioTracksTimerFired(TimerBase*);
- // TODO(liberato): remove once autoplay gesture override experiment concludes.
- void triggerAutoplayViewportCheckForTesting();
-
void scheduleResolvePlayPromises();
void scheduleRejectPlayPromises(ExceptionCode);
void scheduleNotifyPlaying();
@@ -715,16 +704,11 @@ class CORE_EXPORT HTMLMediaElement : public HTMLElement,
AudioSourceProviderImpl m_audioSourceProvider;
- class AutoplayHelperClientImpl;
-
friend class AutoplayUmaHelper; // for isAutoplayAllowedPerSettings
friend class Internals;
friend class TrackDisplayUpdateScope;
- friend class AutoplayExperimentHelper;
friend class MediaControlsTest;
- Member<AutoplayExperimentHelper::Client> m_autoplayHelperClient;
- Member<AutoplayExperimentHelper> m_autoplayHelper;
Member<AutoplayUmaHelper> m_autoplayUmaHelper;
WebRemotePlaybackClient* m_remotePlaybackClient;

Powered by Google App Engine
This is Rietveld 408576698