Deprecating AutoplayExperimentHelper

third_party/WebKit/Source/core/html/HTMLMediaElement.h

 /*
  * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights
  * reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 16 matching lines @@
 #ifndef HTMLMediaElement_h
 #define HTMLMediaElement_h
 
 #include "bindings/core/v8/ActiveScriptWrappable.h"
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/TraceWrapperMember.h"
 #include "core/CoreExport.h"
 #include "core/dom/ActiveDOMObject.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/events/GenericEventQueue.h"
-#include "core/html/AutoplayExperimentHelper.h"
 #include "core/html/HTMLElement.h"
 #include "core/html/track/TextTrack.h"
 #include "platform/MIMETypeRegistry.h"
 #include "platform/Supplementable.h"
 #include "platform/WebTaskRunner.h"
 #include "platform/audio/AudioSourceProvider.h"
 #include "public/platform/WebAudioSourceProviderClient.h"
 #include "public/platform/WebMediaPlayerClient.h"
 #include <memory>
 
@@ skipping 248 matching lines @@
   double effectiveMediaVolume() const;
 
   // Predicates also used when dispatching wrapper creation (cf.
   // [SpecialWrapFor] IDL attribute usage.)
   virtual bool isHTMLAudioElement() const { return false; }
   virtual bool isHTMLVideoElement() const { return false; }
 
   void videoWillBeDrawnToCanvas() const;
 
   // Temporary callback for crbug.com/487345,402044
-  void notifyPositionMayHaveChanged(const IntRect&);
-  void updatePositionNotificationRegistration();
+  //
+  // TODO(zqzhang): remove these callbacks and related plumbing in layout code

[foolip, 2016/11/23 12:40:55]

Can you clean this up now or send a CL based on this showing what it amounts to?
Looks pretty easy to remove.

[Zhiqiang Zhang (Slow), 2016/11/23 18:27:34]

Done.

+  // as AutoplayExperimentHelper is deprecated. See https://crbug.com/666370
+  void notifyPositionMayHaveChanged(const IntRect&) {}
+  void updatePositionNotificationRegistration() {}
 
   WebRemotePlaybackClient* remotePlaybackClient() {
     return m_remotePlaybackClient;
   }
   const WebRemotePlaybackClient* remotePlaybackClient() const {
     return m_remotePlaybackClient;
   }
 
  protected:
   HTMLMediaElement(const QualifiedName&, Document&);
   ~HTMLMediaElement() override;
   void dispose();
 
   void parseAttribute(const QualifiedName&,
                       const AtomicString&,
                       const AtomicString&) override;
   void finishParsingChildren() final;
   bool isURLAttribute(const Attribute&) const override;
   void attachLayoutTree(const AttachContext& = AttachContext()) override;
 
   void didMoveToNewDocument(Document& oldDocument) override;
   virtual KURL posterImageURL() const { return KURL(); }
 
   enum DisplayMode { Unknown, Poster, Video };
   DisplayMode getDisplayMode() const { return m_displayMode; }
   virtual void setDisplayMode(DisplayMode mode) { m_displayMode = mode; }
 
-  void recordAutoplayMetric(AutoplayMetrics);
-
  private:
   void resetMediaPlayerAndMediaSource();
 
   bool alwaysCreateUserAgentShadowRoot() const final { return true; }
   bool areAuthorShadowsAllowed() const final { return false; }
 
   bool supportsFocus() const final;
   bool isMouseFocusable() const final;
   bool layoutObjectIsNeeded(const ComputedStyle&) override;
   LayoutObject* createLayoutObject(const ComputedStyle&) override;
@@ skipping 176 matching lines @@
   bool isGestureNeededForPlayback() const;
 
   // Return true if and only if the settings allow autoplay of media on this
   // frame.
   bool isAutoplayAllowedPerSettings() const;
 
   void setNetworkState(NetworkState);
 
   void audioTracksTimerFired(TimerBase*);
 
-  // TODO(liberato): remove once autoplay gesture override experiment concludes.
-  void triggerAutoplayViewportCheckForTesting();
-
   void scheduleResolvePlayPromises();
   void scheduleRejectPlayPromises(ExceptionCode);
   void scheduleNotifyPlaying();
   void resolveScheduledPlayPromises();
   void rejectScheduledPlayPromises();
   void rejectPlayPromises(ExceptionCode, const String&);
   void rejectPlayPromisesInternal(ExceptionCode, const String&);
 
   EnumerationHistogram& showControlsHistogram() const;
 
@@ skipping 162 matching lines @@
     DECLARE_TRACE();
 
    private:
     WebAudioSourceProvider* m_webAudioSourceProvider;
     Member<AudioClientImpl> m_client;
     Mutex provideInputLock;
   };
 
   AudioSourceProviderImpl m_audioSourceProvider;
 
-  class AutoplayHelperClientImpl;
-
   friend class AutoplayUmaHelper;  // for isAutoplayAllowedPerSettings
   friend class Internals;
   friend class TrackDisplayUpdateScope;
-  friend class AutoplayExperimentHelper;
   friend class MediaControlsTest;
 
-  Member<AutoplayExperimentHelper::Client> m_autoplayHelperClient;
-  Member<AutoplayExperimentHelper> m_autoplayHelper;
   Member<AutoplayUmaHelper> m_autoplayUmaHelper;
 
   WebRemotePlaybackClient* m_remotePlaybackClient;
 
   // class AutoplayVisibilityObserver;
   Member<ElementVisibilityObserver> m_autoplayVisibilityObserver;
 
   static URLRegistry* s_mediaStreamRegistry;
 };
 
 inline bool isHTMLMediaElement(const HTMLElement& element) {
   return isHTMLAudioElement(element) || isHTMLVideoElement(element);
 }
 
 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLMediaElement);
 
 }  // namespace blink
 
 #endif  // HTMLMediaElement_h