third_party/WebKit/Source/core/loader/PingLoader.cpp - Issue 2510333002: Send encoded_body_length to renderer when response completed (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/PingLoader.cpp

Issue 2510333002: Send encoded_body_length to renderer when response completed (2/3) (Closed)

Patch Set: rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fetch/ResourceLoader.cpp ('k') | third_party/WebKit/Source/platform/exported/WebURLLoaderTestDelegate.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/PingLoader.cpp

diff --git a/third_party/WebKit/Source/core/loader/PingLoader.cpp b/third_party/WebKit/Source/core/loader/PingLoader.cpp

index a08a69ef16814229f7f969dbe6c60dd8f1f07518..693c264b04614bf6b0067c8abc0b4d3511e3dd82 100644

--- a/third_party/WebKit/Source/core/loader/PingLoader.cpp

+++ b/third_party/WebKit/Source/core/loader/PingLoader.cpp

@@ -210,9 +210,9 @@ class PingLoaderImpl : public GarbageCollectedFinalized<PingLoaderImpl>,

WebURLRequest&,

const WebURLResponse&) override;

void didReceiveResponse(WebURLLoader*, const WebURLResponse&) final;

- void didReceiveData(WebURLLoader*, const char*, int, int, int) final;

- void didFinishLoading(WebURLLoader*, double, int64_t) final;

- void didFail(WebURLLoader*, const WebURLError&, int64_t) final;

+ void didReceiveData(WebURLLoader*, const char*, int, int) final;

+ void didFinishLoading(WebURLLoader*, double, int64_t, int64_t) final;

+ void didFail(WebURLLoader*, const WebURLError&, int64_t, int64_t) final;

void timeout(TimerBase*);

@@ -346,7 +346,7 @@ void PingLoaderImpl::didReceiveResponse(WebURLLoader*,

dispose();

}

-void PingLoaderImpl::didReceiveData(WebURLLoader*, const char*, int, int, int) {

+void PingLoaderImpl::didReceiveData(WebURLLoader*, const char*, int, int) {

if (LocalFrame* frame = this->frame()) {

TRACE_EVENT1("devtools.timeline", "ResourceFinish", "data",

InspectorResourceFinishEvent::data(m_identifier, 0, true));

@@ -355,7 +355,7 @@ void PingLoaderImpl::didReceiveData(WebURLLoader*, const char*, int, int, int) {

dispose();

}

-void PingLoaderImpl::didFinishLoading(WebURLLoader*, double, int64_t) {

+void PingLoaderImpl::didFinishLoading(WebURLLoader*, double, int64_t, int64_t) {

if (LocalFrame* frame = this->frame()) {

TRACE_EVENT1("devtools.timeline", "ResourceFinish", "data",

InspectorResourceFinishEvent::data(m_identifier, 0, true));

@@ -366,6 +366,7 @@ void PingLoaderImpl::didFinishLoading(WebURLLoader*, double, int64_t) {

void PingLoaderImpl::didFail(WebURLLoader*,

const WebURLError& resourceError,

+ int64_t,

int64_t) {

if (LocalFrame* frame = this->frame()) {

TRACE_EVENT1("devtools.timeline", "ResourceFinish", "data",