content/child/shared_memory_received_data_factory_unittest.cc - Issue 2510333002: Send encoded_body_length to renderer when response completed (2/3)

Unified Diff: content/child/shared_memory_received_data_factory_unittest.cc

Issue 2510333002: Send encoded_body_length to renderer when response completed (2/3) (Closed)

Patch Set: rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Index: content/child/shared_memory_received_data_factory_unittest.cc

diff --git a/content/child/shared_memory_received_data_factory_unittest.cc b/content/child/shared_memory_received_data_factory_unittest.cc

index 8a2411b47b0b104d6b54f2820759e758f5cab570..65bad7c837a2affaa840a97c05e0d5697e63889c 100644

--- a/content/child/shared_memory_received_data_factory_unittest.cc

+++ b/content/child/shared_memory_received_data_factory_unittest.cc

@@ -72,14 +72,13 @@ TEST_F(SharedMemoryReceivedDataFactoryTest, Create) {

EXPECT_CALL(*sender_, SendAck(request_id_));

EXPECT_CALL(checkpoint, Call(1));

- std::unique_ptr<ReceivedData> data = factory_->Create(12, 34, 56, 30);

+ std::unique_ptr<ReceivedData> data = factory_->Create(12, 34, 56);

const char* memory_start = static_cast<const char*>(memory_->memory());

ASSERT_TRUE(data);

EXPECT_EQ(memory_start + 12, data->payload());

EXPECT_EQ(34, data->length());

EXPECT_EQ(56, data->encoded_data_length());

- EXPECT_EQ(30, data->encoded_body_length());

checkpoint.Call(0);

data.reset();

@@ -97,9 +96,9 @@ TEST_F(SharedMemoryReceivedDataFactoryTest, CreateMultiple) {

EXPECT_CALL(*sender_, SendAck(request_id_));

EXPECT_CALL(checkpoint, Call(3));

- std::unique_ptr<ReceivedData> data1 = factory_->Create(0, 1, 1, 1);

- std::unique_ptr<ReceivedData> data2 = factory_->Create(1, 1, 1, 1);

- std::unique_ptr<ReceivedData> data3 = factory_->Create(2, 1, 1, 1);

+ std::unique_ptr<ReceivedData> data1 = factory_->Create(0, 1, 1);

+ std::unique_ptr<ReceivedData> data2 = factory_->Create(1, 1, 1);

+ std::unique_ptr<ReceivedData> data3 = factory_->Create(2, 1, 1);

EXPECT_TRUE(data1);

EXPECT_TRUE(data2);

@@ -125,9 +124,9 @@ TEST_F(SharedMemoryReceivedDataFactoryTest, ReclaimOutOfOrder) {

EXPECT_CALL(*sender_, SendAck(request_id_));

EXPECT_CALL(checkpoint, Call(3));

- std::unique_ptr<ReceivedData> data1 = factory_->Create(0, 1, 1, 1);

- std::unique_ptr<ReceivedData> data2 = factory_->Create(1, 1, 1, 1);

- std::unique_ptr<ReceivedData> data3 = factory_->Create(2, 1, 1, 1);

+ std::unique_ptr<ReceivedData> data1 = factory_->Create(0, 1, 1);

+ std::unique_ptr<ReceivedData> data2 = factory_->Create(1, 1, 1);

+ std::unique_ptr<ReceivedData> data3 = factory_->Create(2, 1, 1);

EXPECT_TRUE(data1);

EXPECT_TRUE(data2);

@@ -157,12 +156,12 @@ TEST_F(SharedMemoryReceivedDataFactoryTest, ReclaimOutOfOrderPartially) {

EXPECT_CALL(*sender_, SendAck(request_id_));

EXPECT_CALL(checkpoint, Call(4));

- std::unique_ptr<ReceivedData> data1 = factory_->Create(0, 1, 1, 1);

- std::unique_ptr<ReceivedData> data2 = factory_->Create(1, 1, 1, 1);

- std::unique_ptr<ReceivedData> data3 = factory_->Create(2, 1, 1, 1);

- std::unique_ptr<ReceivedData> data4 = factory_->Create(3, 1, 1, 1);

- std::unique_ptr<ReceivedData> data5 = factory_->Create(4, 1, 1, 1);

- std::unique_ptr<ReceivedData> data6 = factory_->Create(5, 1, 1, 1);

+ std::unique_ptr<ReceivedData> data1 = factory_->Create(0, 1, 1);

+ std::unique_ptr<ReceivedData> data2 = factory_->Create(1, 1, 1);

+ std::unique_ptr<ReceivedData> data3 = factory_->Create(2, 1, 1);

+ std::unique_ptr<ReceivedData> data4 = factory_->Create(3, 1, 1);

+ std::unique_ptr<ReceivedData> data5 = factory_->Create(4, 1, 1);

+ std::unique_ptr<ReceivedData> data6 = factory_->Create(5, 1, 1);

EXPECT_TRUE(data1);

EXPECT_TRUE(data2);

@@ -195,12 +194,12 @@ TEST_F(SharedMemoryReceivedDataFactoryTest, Stop) {

EXPECT_CALL(checkpoint, Call(2));