Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: chrome/renderer/extensions/extension_localization_peer.cc

Issue 2510333002: Send encoded_body_length to renderer when response completed (2/3) (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/extension_localization_peer.cc
diff --git a/chrome/renderer/extensions/extension_localization_peer.cc b/chrome/renderer/extensions/extension_localization_peer.cc
index 745aabe26a47654277f336fd3d2521eb63f9a47a..7f16703071b4cf0417c5aa62ae8c8f37acbd5978 100644
--- a/chrome/renderer/extensions/extension_localization_peer.cc
+++ b/chrome/renderer/extensions/extension_localization_peer.cc
@@ -27,9 +27,6 @@ class StringData final : public content::RequestPeer::ReceivedData {
const char* payload() const override { return data_.data(); }
int length() const override { return data_.size(); }
int encoded_data_length() const override { return -1; }
- // The original data has substitutions applied, so the original
- // encoded_body_length no longer applies.
- int encoded_body_length() const override { return data_.size(); }
private:
const std::string data_;
@@ -94,14 +91,15 @@ void ExtensionLocalizationPeer::OnCompletedRequest(
bool was_ignored_by_handler,
bool stale_copy_in_cache,
const base::TimeTicks& completion_time,
- int64_t total_transfer_size) {
+ int64_t total_transfer_size,
+ int64_t encoded_body_size) {
// Give sub-classes a chance at altering the data.
if (error_code != net::OK) {
// We failed to load the resource.
original_peer_->OnReceivedResponse(response_info_);
original_peer_->OnCompletedRequest(net::ERR_ABORTED, false,
stale_copy_in_cache, completion_time,
- total_transfer_size);
+ total_transfer_size, encoded_body_size);
return;
}
@@ -112,7 +110,7 @@ void ExtensionLocalizationPeer::OnCompletedRequest(
original_peer_->OnReceivedData(base::MakeUnique<StringData>(data_));
original_peer_->OnCompletedRequest(error_code, was_ignored_by_handler,
stale_copy_in_cache, completion_time,
- total_transfer_size);
+ total_transfer_size, encoded_body_size);
}
void ExtensionLocalizationPeer::ReplaceMessages() {

Powered by Google App Engine
This is Rietveld 408576698