Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: chrome/renderer/extensions/extension_localization_peer_unittest.cc

Issue 2510333002: Send encoded_body_length to renderer when response completed (2/3) (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/extensions/extension_localization_peer.h" 5 #include "chrome/renderer/extensions/extension_localization_peer.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <map> 9 #include <map>
10 #include <memory> 10 #include <memory>
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 MOCK_METHOD2(OnDownloadedData, void(int len, int encoded_data_length)); 72 MOCK_METHOD2(OnDownloadedData, void(int len, int encoded_data_length));
73 void OnReceivedData( 73 void OnReceivedData(
74 std::unique_ptr<RequestPeer::ReceivedData> data) override { 74 std::unique_ptr<RequestPeer::ReceivedData> data) override {
75 OnReceivedDataInternal(data->payload(), data->length(), 75 OnReceivedDataInternal(data->payload(), data->length(),
76 data->encoded_data_length()); 76 data->encoded_data_length());
77 } 77 }
78 MOCK_METHOD3(OnReceivedDataInternal, 78 MOCK_METHOD3(OnReceivedDataInternal,
79 void(const char* data, 79 void(const char* data,
80 int data_length, 80 int data_length,
81 int encoded_data_length)); 81 int encoded_data_length));
82 MOCK_METHOD5(OnCompletedRequest, 82 MOCK_METHOD6(OnCompletedRequest,
83 void(int error_code, 83 void(int error_code,
84 bool was_ignored_by_handler, 84 bool was_ignored_by_handler,
85 bool stale_copy_in_cache, 85 bool stale_copy_in_cache,
86 const base::TimeTicks& completion_time, 86 const base::TimeTicks& completion_time,
87 int64_t total_transfer_size)); 87 int64_t total_transfer_size,
88 int64_t encoded_body_size));
88 89
89 private: 90 private:
90 DISALLOW_COPY_AND_ASSIGN(MockRequestPeer); 91 DISALLOW_COPY_AND_ASSIGN(MockRequestPeer);
91 }; 92 };
92 93
93 } // namespace 94 } // namespace
94 95
95 class ExtensionLocalizationPeerTest : public testing::Test { 96 class ExtensionLocalizationPeerTest : public testing::Test {
96 protected: 97 protected:
97 void SetUp() override { 98 void SetUp() override {
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1)); 132 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1));
132 EXPECT_TRUE(NULL != filter_peer_.get()); 133 EXPECT_TRUE(NULL != filter_peer_.get());
133 } 134 }
134 135
135 TEST_F(ExtensionLocalizationPeerTest, OnReceivedData) { 136 TEST_F(ExtensionLocalizationPeerTest, OnReceivedData) {
136 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1)); 137 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1));
137 EXPECT_TRUE(GetData().empty()); 138 EXPECT_TRUE(GetData().empty());
138 139
139 const std::string data_chunk("12345"); 140 const std::string data_chunk("12345");
140 filter_peer_->OnReceivedData(base::MakeUnique<content::FixedReceivedData>( 141 filter_peer_->OnReceivedData(base::MakeUnique<content::FixedReceivedData>(
141 data_chunk.data(), data_chunk.length(), -1, 0)); 142 data_chunk.data(), data_chunk.length(), -1));
142 143
143 EXPECT_EQ(data_chunk, GetData()); 144 EXPECT_EQ(data_chunk, GetData());
144 145
145 filter_peer_->OnReceivedData(base::MakeUnique<content::FixedReceivedData>( 146 filter_peer_->OnReceivedData(base::MakeUnique<content::FixedReceivedData>(
146 data_chunk.data(), data_chunk.length(), -1, 0)); 147 data_chunk.data(), data_chunk.length(), -1));
147 EXPECT_EQ(data_chunk + data_chunk, GetData()); 148 EXPECT_EQ(data_chunk + data_chunk, GetData());
148 } 149 }
149 150
150 MATCHER_P(IsURLRequestEqual, status, "") { return arg.status() == status; } 151 MATCHER_P(IsURLRequestEqual, status, "") { return arg.status() == status; }
151 152
152 TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestBadURLRequestStatus) { 153 TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestBadURLRequestStatus) {
153 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1)); 154 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1));
154 155
155 EXPECT_CALL(*original_peer_, OnReceivedResponse(_)); 156 EXPECT_CALL(*original_peer_, OnReceivedResponse(_));
156 EXPECT_CALL(*original_peer_, 157 EXPECT_CALL(*original_peer_,
157 OnCompletedRequest(net::ERR_ABORTED, false, false, 158 OnCompletedRequest(net::ERR_ABORTED, false, false,
158 base::TimeTicks(), -1)); 159 base::TimeTicks(), -1, 0));
159 160
160 filter_peer_->OnCompletedRequest(net::ERR_FAILED, false, false, 161 filter_peer_->OnCompletedRequest(net::ERR_FAILED, false, false,
161 base::TimeTicks(), -1); 162 base::TimeTicks(), -1, 0);
162 } 163 }
163 164
164 TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestEmptyData) { 165 TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestEmptyData) {
165 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1)); 166 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1));
166 167
167 EXPECT_CALL(*original_peer_, OnReceivedDataInternal(_, _, _)).Times(0); 168 EXPECT_CALL(*original_peer_, OnReceivedDataInternal(_, _, _)).Times(0);
168 EXPECT_CALL(*sender_, Send(_)).Times(0); 169 EXPECT_CALL(*sender_, Send(_)).Times(0);
169 170
170 EXPECT_CALL(*original_peer_, OnReceivedResponse(_)); 171 EXPECT_CALL(*original_peer_, OnReceivedResponse(_));
171 EXPECT_CALL(*original_peer_, 172 EXPECT_CALL(*original_peer_, OnCompletedRequest(net::OK, false, false,
172 OnCompletedRequest(net::OK, false, false, base::TimeTicks(), -1)); 173 base::TimeTicks(), -1, 0));
173 174
174 filter_peer_->OnCompletedRequest(net::OK, false, false, base::TimeTicks(), 175 filter_peer_->OnCompletedRequest(net::OK, false, false, base::TimeTicks(), -1,
175 -1); 176 0);
176 } 177 }
177 178
178 TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestNoCatalogs) { 179 TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestNoCatalogs) {
179 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1)); 180 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1));
180 181
181 SetData("some text"); 182 SetData("some text");
182 183
183 EXPECT_CALL(*sender_, Send(_)); 184 EXPECT_CALL(*sender_, Send(_));
184 185
185 std::string data = GetData(); 186 std::string data = GetData();
186 EXPECT_CALL(*original_peer_, OnReceivedResponse(_)).Times(1); 187 EXPECT_CALL(*original_peer_, OnReceivedResponse(_)).Times(1);
187 EXPECT_CALL(*original_peer_, 188 EXPECT_CALL(*original_peer_,
188 OnReceivedDataInternal(StrEq(data.c_str()), data.length(), -1)) 189 OnReceivedDataInternal(StrEq(data.c_str()), data.length(), -1))
189 .Times(1); 190 .Times(1);
190 EXPECT_CALL(*original_peer_, 191 EXPECT_CALL(*original_peer_, OnCompletedRequest(net::OK, false, false,
191 OnCompletedRequest(net::OK, false, false, base::TimeTicks(), -1)) 192 base::TimeTicks(), -1, -1))
192 .Times(1); 193 .Times(1);
193 194
194 filter_peer_->OnCompletedRequest(net::OK, false, false, base::TimeTicks(), 195 filter_peer_->OnCompletedRequest(net::OK, false, false, base::TimeTicks(), -1,
195 -1); 196 -1);
196 197
197 // Test if Send gets called again (it shouldn't be) when first call returned 198 // Test if Send gets called again (it shouldn't be) when first call returned
198 // an empty dictionary. 199 // an empty dictionary.
199 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1)); 200 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1));
200 EXPECT_CALL(*original_peer_, OnReceivedResponse(_)).Times(1); 201 EXPECT_CALL(*original_peer_, OnReceivedResponse(_)).Times(1);
201 EXPECT_CALL(*original_peer_, 202 EXPECT_CALL(*original_peer_,
202 OnReceivedDataInternal(StrEq(data.c_str()), data.length(), -1)) 203 OnReceivedDataInternal(StrEq(data.c_str()), data.length(), -1))
203 .Times(1); 204 .Times(1);
204 EXPECT_CALL(*original_peer_, 205 EXPECT_CALL(*original_peer_, OnCompletedRequest(net::OK, false, false,
205 OnCompletedRequest(net::OK, false, false, base::TimeTicks(), -1)) 206 base::TimeTicks(), -1, -1))
206 .Times(1); 207 .Times(1);
207 SetData("some text"); 208 SetData("some text");
208 filter_peer_->OnCompletedRequest(net::OK, false, false, base::TimeTicks(), 209 filter_peer_->OnCompletedRequest(net::OK, false, false, base::TimeTicks(), -1,
209 -1); 210 -1);
210 } 211 }
211 212
212 TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestWithCatalogs) { 213 TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestWithCatalogs) {
213 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_2)); 214 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_2));
214 215
215 extensions::L10nMessagesMap messages; 216 extensions::L10nMessagesMap messages;
216 messages.insert(std::make_pair("text", "new text")); 217 messages.insert(std::make_pair("text", "new text"));
217 extensions::ExtensionToL10nMessagesMap& l10n_messages_map = 218 extensions::ExtensionToL10nMessagesMap& l10n_messages_map =
218 *extensions::GetExtensionToL10nMessagesMap(); 219 *extensions::GetExtensionToL10nMessagesMap();
219 l10n_messages_map["some_id2"] = messages; 220 l10n_messages_map["some_id2"] = messages;
220 221
221 SetData("some __MSG_text__"); 222 SetData("some __MSG_text__");
222 223
223 // We already have messages in memory, Send will be skipped. 224 // We already have messages in memory, Send will be skipped.
224 EXPECT_CALL(*sender_, Send(_)).Times(0); 225 EXPECT_CALL(*sender_, Send(_)).Times(0);
225 226
226 // __MSG_text__ gets replaced with "new text". 227 // __MSG_text__ gets replaced with "new text".
227 std::string data("some new text"); 228 std::string data("some new text");
228 EXPECT_CALL(*original_peer_, OnReceivedResponse(_)); 229 EXPECT_CALL(*original_peer_, OnReceivedResponse(_));
229 EXPECT_CALL(*original_peer_, 230 EXPECT_CALL(*original_peer_,
230 OnReceivedDataInternal(StrEq(data.c_str()), data.length(), -1)); 231 OnReceivedDataInternal(StrEq(data.c_str()), data.length(), -1));
231 232
232 EXPECT_CALL(*original_peer_, 233 EXPECT_CALL(*original_peer_, OnCompletedRequest(net::OK, false, false,
233 OnCompletedRequest(net::OK, false, false, base::TimeTicks(), -1)); 234 base::TimeTicks(), -1, -1));
234 235
235 filter_peer_->OnCompletedRequest(net::OK, false, false, base::TimeTicks(), 236 filter_peer_->OnCompletedRequest(net::OK, false, false, base::TimeTicks(), -1,
236 -1); 237 -1);
237 } 238 }
238 239
239 TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestReplaceMessagesFails) { 240 TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestReplaceMessagesFails) {
240 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_3)); 241 SetUpExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_3));
241 242
242 extensions::L10nMessagesMap messages; 243 extensions::L10nMessagesMap messages;
243 messages.insert(std::make_pair("text", "new text")); 244 messages.insert(std::make_pair("text", "new text"));
244 extensions::ExtensionToL10nMessagesMap& l10n_messages_map = 245 extensions::ExtensionToL10nMessagesMap& l10n_messages_map =
245 *extensions::GetExtensionToL10nMessagesMap(); 246 *extensions::GetExtensionToL10nMessagesMap();
246 l10n_messages_map["some_id3"] = messages; 247 l10n_messages_map["some_id3"] = messages;
247 248
248 std::string message("some __MSG_missing_message__"); 249 std::string message("some __MSG_missing_message__");
249 SetData(message); 250 SetData(message);
250 251
251 // We already have messages in memory, Send will be skipped. 252 // We already have messages in memory, Send will be skipped.
252 EXPECT_CALL(*sender_, Send(_)).Times(0); 253 EXPECT_CALL(*sender_, Send(_)).Times(0);
253 254
254 // __MSG_missing_message__ is missing, so message stays the same. 255 // __MSG_missing_message__ is missing, so message stays the same.
255 EXPECT_CALL(*original_peer_, OnReceivedResponse(_)); 256 EXPECT_CALL(*original_peer_, OnReceivedResponse(_));
256 EXPECT_CALL(*original_peer_, OnReceivedDataInternal(StrEq(message.c_str()), 257 EXPECT_CALL(*original_peer_, OnReceivedDataInternal(StrEq(message.c_str()),
257 message.length(), -1)); 258 message.length(), -1));
258 259
259 EXPECT_CALL(*original_peer_, 260 EXPECT_CALL(*original_peer_, OnCompletedRequest(net::OK, false, false,
260 OnCompletedRequest(net::OK, false, false, base::TimeTicks(), -1)); 261 base::TimeTicks(), -1, 0));
261 262
262 filter_peer_->OnCompletedRequest(net::OK, false, false, base::TimeTicks(), 263 filter_peer_->OnCompletedRequest(net::OK, false, false, base::TimeTicks(), -1,
263 -1); 264 0);
264 } 265 }
OLDNEW
« no previous file with comments | « chrome/renderer/extensions/extension_localization_peer.cc ('k') | chrome/renderer/security_filter_peer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698