third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp - Issue 2510313004: Use LayoutBox::frameRect() as the viewport of LayoutSVGForeignObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

Issue 2510313004: Use LayoutBox::frameRect() as the viewport of LayoutSVGForeignObject (Closed)

Patch Set: crbug.com/667071 Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp ('k') | third_party/WebKit/Source/core/paint/SVGForeignObjectPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

index 26e1db026b863ac2f7e4b1830b15708bc6d3452d..506986cc883f36bbcaa8c61bb21199a55307516f 100644

--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

@@ -1690,7 +1690,7 @@ TEST_P(PaintPropertyTreeBuilderTest, SvgRootAndForeignObjectPixelSnapping) {

EXPECT_EQ(nullptr, svgProperties->paintOffsetTranslation());

EXPECT_EQ(LayoutPoint(LayoutUnit(8.6), LayoutUnit(8.3)),

svgProperties->localBorderBoxProperties()->paintOffset);

- // Paint offset of SVGRoot be baked into svgLocalToBorderBoxTransform after

+ // Paint offset of SVGRoot is baked into svgLocalToBorderBoxTransform after

// snapped to pixels.

EXPECT_EQ(TransformationMatrix().translate(9, 8),

svgProperties->svgLocalToBorderBoxTransform()->matrix());