Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2510313003: Fix location bar jump when focusing/unfocusing on phones. (Closed)

Created:
4 years, 1 month ago by Ted C
Modified:
4 years, 1 month ago
Reviewers:
fgorski
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix location bar jump when focusing/unfocusing on phones. BUG=666831 Committed: https://crrev.com/8a52ef3926c71f160500c7257111c80f9e670e5b Cr-Commit-Position: refs/heads/master@{#433285}

Patch Set 1 #

Patch Set 2 : Fix comment grammar mistakes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Ted C
PTAL I played around a bit with offline and didn't see any issues with this, ...
4 years, 1 month ago (2016-11-18 18:45:07 UTC) #2
fgorski
lgtm
4 years, 1 month ago (2016-11-18 18:51:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510313003/20001
4 years, 1 month ago (2016-11-18 18:56:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-18 20:18:25 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 20:23:27 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8a52ef3926c71f160500c7257111c80f9e670e5b
Cr-Commit-Position: refs/heads/master@{#433285}

Powered by Google App Engine
This is Rietveld 408576698