Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: ui/android/java/res/layout/dropdown_item.xml

Issue 2510283002: Http Bad: Put icon on the left of warning message and make value and label in one line on Android (Closed)
Patch Set: minor change Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/android/java/res/layout/dropdown_item.xml
diff --git a/ui/android/java/res/layout/dropdown_item.xml b/ui/android/java/res/layout/dropdown_item.xml
index e7dc3932c45eff484a269add2c786a5c6340d1fa..29964fbffb17c26c27b5d1f267515d237d557c64 100644
--- a/ui/android/java/res/layout/dropdown_item.xml
+++ b/ui/android/java/res/layout/dropdown_item.xml
@@ -13,6 +13,13 @@
<!-- These layout params are overwritten in DropdownAdapter.java -->
+ <ImageView
+ android:id="@+id/start_dropdown_icon"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:layout_margin="8dp"
+ android:contentDescription="@null" />
+
<LinearLayout
android:id="@+id/dropdown_label_wrapper"
android:layout_width="0dp"
@@ -25,8 +32,8 @@
android:id="@+id/dropdown_label"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
- android:layout_marginEnd="10dp"
- android:layout_marginStart="10dp"
+ android:layout_marginEnd="@dimen/dropdown_item_label_margin"
+ android:layout_marginStart="@dimen/dropdown_item_label_margin"
android:ellipsize="end"
android:includeFontPadding="false"
android:singleLine="true"
@@ -49,7 +56,7 @@
</LinearLayout>
<ImageView
- android:id="@+id/dropdown_icon"
+ android:id="@+id/end_dropdown_icon"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_margin="8dp"

Powered by Google App Engine
This is Rietveld 408576698