Issue 251024: Add GetPreferredTrySlaves() to presubmit scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 251024: Add GetPreferredTrySlaves() to presubmit scripts. (Closed)

Created:
11 years, 2 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, M-A Ruel, bradn

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add GetPreferredTrySlaves() to presubmit scripts. BUG=23071 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27449

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -0 lines)			Patch
M	PRESUBMIT.py	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	chrome/browser/views/PRESUBMIT.py	View	1 chunk	+13 lines, -0 lines	0 comments	Download
A	views/PRESUBMIT.py	View	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bradn

11 years, 2 months ago (2009-09-29 01:35:55 UTC) #3

LGTM
oops...
It hadn't occurred to be before, but this basically obligates us to have
PRESUBMIT scripts for any project that has trybots, but that's probably sensible
anyhow.

Expand Messages | Collapse Messages