Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 251023005: Renamed ServiceDiscoveryClientMdns to ServiceDiscoveryClientUtility. (Closed)

Created:
6 years, 8 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 7 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews
Visibility:
Public.

Description

Renamed ServiceDiscoveryClientMdns to ServiceDiscoveryClientUtility. BUG=349645 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266697

Patch Set 1 #

Patch Set 2 : Sat 04/26/2014 18:41:53.09 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -192 lines) Patch
D chrome/browser/local_discovery/service_discovery_client_mdns.h View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/local_discovery/service_discovery_client_mdns.cc View 1 chunk +0 lines, -107 lines 0 comments Download
A + chrome/browser/local_discovery/service_discovery_client_utility.h View 1 3 chunks +11 lines, -9 lines 0 comments Download
A + chrome/browser/local_discovery/service_discovery_client_utility.cc View 1 7 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/local_discovery/service_discovery_host_client.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/local_discovery/service_discovery_shared_client.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 7 months ago (2014-04-28 16:25:46 UTC) #1
Noam Samuel
lgtm
6 years, 7 months ago (2014-04-28 18:24:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/251023005/20001
6 years, 7 months ago (2014-04-28 18:26:08 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 18:43:13 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_gn_rel
6 years, 7 months ago (2014-04-28 18:43:14 UTC) #5
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-04-28 19:23:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/251023005/20001
6 years, 7 months ago (2014-04-28 19:24:12 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 23:52:19 UTC) #8
Message was sent while issue was closed.
Change committed as 266697

Powered by Google App Engine
This is Rietveld 408576698