Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: Source/platform/graphics/gpu/DrawingBufferTest.cpp

Issue 251023004: WebGL: Free temporary GPU resources held by inactive or hidden WebGL. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use ASSERT instead of 'if' in prepareMailbox() Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 602 matching lines...) Expand 10 before | Expand all | Expand 10 after
613 EXPECT_NE(trackingContext->stencilAttachment(), trackingContext->dep thAttachment()); 613 EXPECT_NE(trackingContext->stencilAttachment(), trackingContext->dep thAttachment());
614 } else { 614 } else {
615 EXPECT_EQ(0u, trackingContext->stencilAttachment()); 615 EXPECT_EQ(0u, trackingContext->stencilAttachment());
616 EXPECT_EQ(0u, trackingContext->depthAttachment()); 616 EXPECT_EQ(0u, trackingContext->depthAttachment());
617 } 617 }
618 618
619 drawingBuffer->beginDestruction(); 619 drawingBuffer->beginDestruction();
620 } 620 }
621 } 621 }
622 622
623 TEST_F(DrawingBufferTest, verifySetIsHiddenProperlyAffectsMailboxes)
624 {
625 blink::WebExternalTextureMailbox mailbox;
626
627 // Produce mailboxes.
628 m_drawingBuffer->markContentsChanged();
629 EXPECT_TRUE(m_drawingBuffer->prepareMailbox(&mailbox, 0));
630
631 unsigned waitSyncPoint = webContext()->insertSyncPoint();
632 mailbox.syncPoint = waitSyncPoint;
633 m_drawingBuffer->setIsHidden(true);
634 m_drawingBuffer->mailboxReleased(mailbox);
635 // m_drawingBuffer deletes mailbox immediately when hidden.
636 EXPECT_EQ(waitSyncPoint, webContext()->mostRecentlyWaitedSyncPoint());
637
dshwang 2014/07/09 17:40:54 Remove EXPECT_FALSE(m_drawingBuffer->prepareMailbo
638 m_drawingBuffer->beginDestruction();
639 }
640
623 } // namespace 641 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698