Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: appengine/findit/model/flake/test/master_flake_analysis_test.py

Issue 2510223003: [Findit] Fixing analysis mismatch in check flake (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/model/flake/test/flake_analysis_request_test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/model/flake/test/master_flake_analysis_test.py
diff --git a/appengine/findit/model/flake/test/master_flake_analysis_test.py b/appengine/findit/model/flake/test/master_flake_analysis_test.py
index edc5e946dc0f51c58ac10160454a1782632e7d5f..fcdace3bb54887aba7b653c4e81579031e68b6f6 100644
--- a/appengine/findit/model/flake/test/master_flake_analysis_test.py
+++ b/appengine/findit/model/flake/test/master_flake_analysis_test.py
@@ -137,3 +137,20 @@ class MasterFlakeAnalysisTest(unittest.TestCase):
analysis = MasterFlakeAnalysis.Create('m', 'b', 123, 's', 't')
analysis.algorithm_parameters = algorithm_parameters
self.assertEqual(expected_rerun, analysis.iterations_to_rerun)
+
+ def testGetBuildConfigurationFromKey(self):
+ master_name = 'm'
+ builder_name = 'b'
+ build_number = 123
+ step_name = 's'
+ test_name = 't'
+
+ key = MasterFlakeAnalysis.Create(
+ master_name, builder_name, build_number, step_name, test_name).key
+
+ self.assertEqual(
+ (None, None),
+ MasterFlakeAnalysis.GetBuildConfigurationFromKey(None))
+ self.assertEqual(
+ (master_name, builder_name),
+ MasterFlakeAnalysis.GetBuildConfigurationFromKey(key))
« no previous file with comments | « appengine/findit/model/flake/test/flake_analysis_request_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698