Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: appengine/findit/model/flake/master_flake_analysis.py

Issue 2510223003: [Findit] Fixing analysis mismatch in check flake (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/model/flake/master_flake_analysis.py
diff --git a/appengine/findit/model/flake/master_flake_analysis.py b/appengine/findit/model/flake/master_flake_analysis.py
index 63af721a0b1bad6f416ed791186144500a5d346b..ed71471f0e05a814917e6b32bbe283c5ffd4e652 100644
--- a/appengine/findit/model/flake/master_flake_analysis.py
+++ b/appengine/findit/model/flake/master_flake_analysis.py
@@ -11,8 +11,8 @@ from model import result_status
from model import triage_status
from model.base_analysis import BaseAnalysis
from model.base_build_model import BaseBuildModel
-from model.flake.flake_swarming_task import FlakeSwarmingTaskData
from model.base_triaged_model import TriagedModel
+from model.flake.flake_swarming_task import FlakeSwarmingTaskData
class DataPoint(ndb.Model):
@@ -51,6 +51,17 @@ class MasterFlakeAnalysis(
return '%s/%s/%s/%s/%s' % (
master_name, builder_name, build_number, step_name, encoded_test_name)
+ @staticmethod
+ def GetBuildConfigurationFromKey(master_flake_analysis_key):
+ """Extracts master_name and builder_name from key."""
+ if not master_flake_analysis_key:
+ return None, None
+
+ components = master_flake_analysis_key.pairs()[0][1].split('/')
+ master_name = components[0]
+ builder_name = components[1]
+ return master_name, builder_name
+
# Arguments number differs from overridden method - pylint: disable=W0221
@classmethod
def Create(cls, master_name, builder_name, build_number, step_name,

Powered by Google App Engine
This is Rietveld 408576698