Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: appengine/findit/handlers/flake/test/check_flake_test.py

Issue 2510223003: [Findit] Fixing analysis mismatch in check flake (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/handlers/flake/test/check_flake_test.py
diff --git a/appengine/findit/handlers/flake/test/check_flake_test.py b/appengine/findit/handlers/flake/test/check_flake_test.py
index 148d1a47c811a912821a837ec47db816ed72af78..b443923406595417ae615fa01ea439713dda22b8 100644
--- a/appengine/findit/handlers/flake/test/check_flake_test.py
+++ b/appengine/findit/handlers/flake/test/check_flake_test.py
@@ -15,6 +15,7 @@ from handlers.flake import check_flake
from handlers.flake.check_flake import CheckFlake
from model import analysis_status
from model.analysis_status import STATUS_TO_DESCRIPTION
+from model.flake.flake_analysis_request import BuildStep
from model.flake.flake_analysis_request import FlakeAnalysisRequest
from model.flake.master_flake_analysis import DataPoint
from model.flake.master_flake_analysis import MasterFlakeAnalysis
@@ -166,8 +167,13 @@ class CheckFlakeTest(wf_testcase.WaterfallTestCase):
previous_analysis.Save()
previous_request = FlakeAnalysisRequest.Create(test_name, False, None)
- previous_request.AddBuildStep(
+ build_step = BuildStep.Create(
master_name, builder_name, build_number, step_name, None)
+ build_step.wf_master_name = build_step.master_name
+ build_step.wf_builder_name = build_step.builder_name
+ build_step.wf_build_number = build_step.build_number
+ build_step.wf_step_name = build_step.step_name
+ previous_request.build_steps.append(build_step)
previous_request.analyses.append(previous_analysis.key)
previous_request.Save()
@@ -218,7 +224,6 @@ class CheckFlakeTest(wf_testcase.WaterfallTestCase):
master_name, builder_name, build_number, step_name, None)
previous_request.swarmed = False
previous_request.supported = False
- previous_request.Save()
self.assertRaisesRegexp(
webtest.app.AppError,
« no previous file with comments | « appengine/findit/handlers/flake/check_flake.py ('k') | appengine/findit/model/flake/flake_analysis_request.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698