core/fpdfapi/parser/cpdf_string.h - Issue 2510223002: Make CPDF_Dictionary use unique pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/parser/cpdf_string.h

Issue 2510223002: Make CPDF_Dictionary use unique pointers. (Closed)

Patch Set: rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/parser/cpdf_string.h

diff --git a/core/fpdfapi/parser/cpdf_string.h b/core/fpdfapi/parser/cpdf_string.h

index 616e3b593de6a5948b680ad376922e73945088e8..6698d8c5be8dcbfcff9d4392b1e19ad7ab6eef80 100644

--- a/core/fpdfapi/parser/cpdf_string.h

+++ b/core/fpdfapi/parser/cpdf_string.h

@@ -7,6 +7,8 @@

#ifndef CORE_FPDFAPI_PARSER_CPDF_STRING_H_

#define CORE_FPDFAPI_PARSER_CPDF_STRING_H_

+#include <memory>

#include "core/fpdfapi/parser/cpdf_object.h"

#include "core/fxcrt/cfx_string_pool_template.h"

#include "core/fxcrt/cfx_weak_ptr.h"

@@ -19,7 +21,7 @@ class CPDF_String : public CPDF_Object {

CPDF_String(CFX_WeakPtr<CFX_ByteStringPool> pPool,

const CFX_ByteString& str,

bool bHex);

- explicit CPDF_String(const CFX_WideString& str);

+ CPDF_String(CFX_WeakPtr<CFX_ByteStringPool> pPool, const CFX_WideString& str);

~CPDF_String() override;

// CPDF_Object:

« no previous file with comments | « core/fpdfapi/parser/cpdf_stream.cpp ('k') | core/fpdfapi/parser/cpdf_string.cpp » ('j') | no next file with comments »