xfa/fxfa/app/xfa_fontmgr.cpp - Issue 2510223002: Make CPDF_Dictionary use unique pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/app/xfa_fontmgr.cpp

Issue 2510223002: Make CPDF_Dictionary use unique pointers. (Closed)

Patch Set: Plug leaks Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/app/xfa_fontmgr.cpp

diff --git a/xfa/fxfa/app/xfa_fontmgr.cpp b/xfa/fxfa/app/xfa_fontmgr.cpp

index ddac27d533e61624bf98de933e9bb1e86b8e4f62..857c1d53f775f77b1c4aa31533a1750df1393a03 100644

--- a/xfa/fxfa/app/xfa_fontmgr.cpp

+++ b/xfa/fxfa/app/xfa_fontmgr.cpp

@@ -1839,7 +1839,7 @@ CFGAS_GEFont* CXFA_PDFFontMgr::FindFont(const CFX_ByteString& strPsName,

CFGAS_FontMgr* pFDEFontMgr = m_pDoc->GetApp()->GetFDEFontMgr();

for (const auto& it : *pFontSetDict) {

const CFX_ByteString& key = it.first;

- CPDF_Object* pObj = it.second;

+ CPDF_Object* pObj = it.second.get();

if (!PsNameMatchDRFontName(name.AsStringC(), bBold, bItalic, key,

bStrictMatch)) {

continue;