Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: core/fxge/dib/fx_dib_engine_unittest.cpp

Issue 2510223002: Make CPDF_Dictionary use unique pointers. (Closed)
Patch Set: Plug leaks Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« core/fpdfdoc/cpvt_generateap.cpp ('K') | « core/fpdfdoc/cpvt_generateap.cpp ('k') | fpdfsdk/cpdfsdk_annothandlermgr.cpp » ('j') | testing/libfuzzer/pdf_hint_table_fuzzer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fxge/dib/fx_dib_engine_unittest.cpp
diff --git a/core/fxge/dib/fx_dib_engine_unittest.cpp b/core/fxge/dib/fx_dib_engine_unittest.cpp
index 57e829e9d2babe19182481ee5d3c4c63c522aa23..faacebd5fc7546196960e74b91990dbbcb0e08ac 100644
--- a/core/fxge/dib/fx_dib_engine_unittest.cpp
+++ b/core/fxge/dib/fx_dib_engine_unittest.cpp
@@ -18,8 +18,8 @@ TEST(CStretchEngine, OverflowInCtor) {
FX_RECT clip_rect;
std::unique_ptr<CPDF_Dictionary> dict_obj =
pdfium::MakeUnique<CPDF_Dictionary>();
- dict_obj->SetFor("Width", new CPDF_Number(71000));
- dict_obj->SetFor("Height", new CPDF_Number(12500));
+ dict_obj->SetNewFor<CPDF_Number>("Width", 71000);
+ dict_obj->SetNewFor<CPDF_Number>("Height", 12500);
std::unique_ptr<CPDF_Stream> stream =
pdfium::MakeUnique<CPDF_Stream>(nullptr, 0, dict_obj.release());
CPDF_DIBSource dib_source;
« core/fpdfdoc/cpvt_generateap.cpp ('K') | « core/fpdfdoc/cpvt_generateap.cpp ('k') | fpdfsdk/cpdfsdk_annothandlermgr.cpp » ('j') | testing/libfuzzer/pdf_hint_table_fuzzer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698