core/fpdfapi/parser/cpdf_data_avail.cpp - Issue 2510223002: Make CPDF_Dictionary use unique pointers. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(86)

My Issues | Starred Open | Closed | All

Unified Diff: core/fpdfapi/parser/cpdf_data_avail.cpp

Issue 2510223002: Make CPDF_Dictionary use unique pointers. (Closed)

Patch Set: Plug leaks Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« core/fpdfapi/page/cpdf_streamparser.cpp ('K') | « core/fpdfapi/parser/cfdf_document.cpp ('k') | core/fpdfapi/parser/cpdf_dictionary.h » ('j') | core/fpdfapi/parser/cpdf_document_unittest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: core/fpdfapi/parser/cpdf_data_avail.cpp

diff --git a/core/fpdfapi/parser/cpdf_data_avail.cpp b/core/fpdfapi/parser/cpdf_data_avail.cpp

index 6af2da6ff0df5319e279d048de45bf881864d2d4..1ac6e06a97ff2e4b55563bcda1e9a2e499304558 100644

--- a/core/fpdfapi/parser/cpdf_data_avail.cpp

+++ b/core/fpdfapi/parser/cpdf_data_avail.cpp

@@ -142,10 +142,8 @@ bool CPDF_DataAvail::AreObjectsAvailable(std::vector<CPDF_Object*>& obj_array,

continue;

for (const auto& it : *pDict) {

- const CFX_ByteString& key = it.first;

- CPDF_Object* value = it.second;

- if (key != "Parent")

- new_obj_array.push_back(value);

+ if (it.first != "Parent")

+ new_obj_array.push_back(it.second.get());

}

} break;

case CPDF_Object::REFERENCE: {

« core/fpdfapi/page/cpdf_streamparser.cpp ('K') | « core/fpdfapi/parser/cfdf_document.cpp ('k') | core/fpdfapi/parser/cpdf_dictionary.h » ('j') | core/fpdfapi/parser/cpdf_document_unittest.cpp » ('J')

Powered by Google App Engine

This is Rietveld 408576698