core/fpdfapi/page/cpdf_colorspace.cpp - Issue 2510223002: Make CPDF_Dictionary use unique pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/page/cpdf_colorspace.cpp

Issue 2510223002: Make CPDF_Dictionary use unique pointers. (Closed)

Patch Set: Plug leaks Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/page/cpdf_colorspace.cpp

diff --git a/core/fpdfapi/page/cpdf_colorspace.cpp b/core/fpdfapi/page/cpdf_colorspace.cpp

index 0c023d19ff90ea7ec3dd6cbecbd34810e21c848c..b1675d87a7651428aa03a94c3e90f75170e867ca 100644

--- a/core/fpdfapi/page/cpdf_colorspace.cpp

+++ b/core/fpdfapi/page/cpdf_colorspace.cpp

@@ -345,7 +345,7 @@ std::unique_ptr<CPDF_ColorSpace> CPDF_ColorSpace::Load(CPDF_Document* pDoc,

for (const auto& it : *pDict) {

std::unique_ptr<CPDF_ColorSpace> pRet;

- CPDF_Object* pValue = it.second;

+ CPDF_Object* pValue = it.second.get();

if (ToName(pValue))

pRet.reset(ColorspaceFromName(pValue->GetString()));

if (pRet)