Make CPDF_Dictionary use unique pointers.

testing/libfuzzer/pdf_hint_table_fuzzer.cc

 // Copyright 2016 The PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <cstdint>
 
 #include "core/fpdfapi/parser/cpdf_array.h"
+#include "core/fpdfapi/parser/cpdf_boolean.h"
 #include "core/fpdfapi/parser/cpdf_dictionary.h"
 #include "core/fpdfapi/parser/cpdf_hint_tables.h"
 #include "core/fpdfapi/parser/cpdf_linearized_header.h"
 #include "core/fpdfapi/parser/cpdf_number.h"
 #include "third_party/base/ptr_util.h"
 
 int32_t GetData(const int32_t** data32, const uint8_t** data, size_t* size) {
   const int32_t* ret = *data32;
   ++(*data32);
   *data += 4;
@@ skipping 37 matching lines @@
   // Need 28 bytes for |linearized_dict|.
   // The header section of page offset hint table is 36 bytes.
   // The header section of shared object hint table is 24 bytes.
   if (size < 28 + 36 + 24)
     return 0;
 
   const int32_t* data32 = reinterpret_cast<const int32_t*>(data);
 
   auto linearized_dict = pdfium::MakeUnique<CPDF_Dictionary>();
   // Set initial value.
-  linearized_dict->SetBooleanFor("Linearized", true);
+  linearized_dict->SetNewFor<CPDF_Boolean>("Linearized", true);
   // Set first page end offset
-  linearized_dict->SetIntegerFor("E", GetData(&data32, &data, &size));
+  linearized_dict->SetNewFor<CPDF_Number>("E", GetData(&data32, &data, &size));
   // Set page count
-  linearized_dict->SetIntegerFor("N", GetData(&data32, &data, &size));
+  linearized_dict->SetNewFor<CPDF_Number>("N", GetData(&data32, &data, &size));
   // Set first page obj num
-  linearized_dict->SetIntegerFor("O", GetData(&data32, &data, &size));
+  linearized_dict->SetNewFor<CPDF_Number>("O", GetData(&data32, &data, &size));
   // Set first page no
-  linearized_dict->SetIntegerFor("P", GetData(&data32, &data, &size));
+  linearized_dict->SetNewFor<CPDF_Number>("P", GetData(&data32, &data, &size));
 
   auto hint_info = pdfium::MakeUnique<CPDF_Array>();
   // Add primary hint stream offset
   hint_info->AddNew<CPDF_Number>(GetData(&data32, &data, &size));
   // Add primary hint stream size
   hint_info->AddNew<CPDF_Number>(GetData(&data32, &data, &size));
   // Set hint stream info.
-  linearized_dict->SetFor("H", hint_info.release());
+  linearized_dict->SetFor("H", std::move(hint_info));

[Lei Zhang, 2016/11/18 04:14:20]

#include <utility>, maybe also check other places. "git cl lint" can find them
for you.

 
   const int shared_hint_table_offset = GetData(&data32, &data, &size);
 
   {
     FakeLinearized linearized(linearized_dict.get());
     HintTableForFuzzing hint_table(&linearized, shared_hint_table_offset);
     hint_table.Fuzz(data, size);
   }
   return 0;
 }