Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 251021: Re-add valgrind suppression for bug 16584. (Closed)

Created:
11 years, 2 months ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
mattm
CC:
chromium-reviews_googlegroups.com, not_the_right_glider, Nirnimesh, Timur Iskhodzhanov, dank, stuartmorgan, pam+watch_chromium.org
Visibility:
Public.

Description

Re-add valgrind suppression for bug 16584. BUG=16584 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27454

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
11 years, 2 months ago (2009-09-28 22:04:54 UTC) #1
mattm
lgtm
11 years, 2 months ago (2009-09-28 22:08:30 UTC) #2
mattm
hm, actually will that match? it looks a little different On 2009/09/28 22:08:30, mattm wrote: ...
11 years, 2 months ago (2009-09-28 22:09:23 UTC) #3
mattm
Didn't look too closely to see if the signatures of the rest exactly match or ...
11 years, 2 months ago (2009-09-28 22:12:31 UTC) #4
Lei Zhang
Ok, put into the right place and widened a bit.
11 years, 2 months ago (2009-09-29 01:52:21 UTC) #5
mattm
11 years, 2 months ago (2009-09-29 02:08:17 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698